change signed int shifts to unsigned

[dan131riley]

PR description:

CondFormats/L1TObjects/src/LUT.cc has a couple of shifts, found by UBSAN, that overflow a signed int. This PR changes these to unsigned int shifts (it's pretty clear from the code that this was the intent).

PR validation:

Prior to this PR, several workflows log UBSAN errors of the form:

CMSSW_12_3_UBSAN_X_2022-02-04-1100/src/CondFormats/L1TObjects/src/LUT.cc:83:42: runtime error: signed integer overflow: -2147483648 - 1 cannot be represented in type 'int'

With this PR, those runtime errors are fixed.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36905/28207

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @dan131riley (Dan Riley) for master.

It involves the following packages:

• CondFormats/L1TObjects (l1, db, alca)

@malbouis, @yuanchao, @epalencia, @cmsbuild, @rekovic, @ggovi, @tvami, @cecilecaillol, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich, @tocheng, @seemasharmafnal this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[tvami]

type bug-fix

[tvami]

@cmsbuild , please test

[tvami]

@cmsbuild , please test for CMSSW_12_3_UBSAN_X

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-396742/22273/summary.html
COMMIT: 3aa02fc
CMSSW: CMSSW_12_3_X_2022-02-07-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36905/22273/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 46
• DQMHistoTests: Total histograms compared: 3766018
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3765988
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 45 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 193 log files, 42 edm output root files, 46 DQM output files
• TriggerResults: no differences found

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-396742/22274/summary.html
COMMIT: 3aa02fc
CMSSW: CMSSW_12_3_UBSAN_X_2022-02-05-1100/slc7_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36905/22274/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 127276 lines to the logs
• Reco comparison results: 69520 differences found in the comparisons
• DQMHistoTests: Total files compared: 46
• DQMHistoTests: Total histograms compared: 3766018
• DQMHistoTests: Total failures: 269431
• DQMHistoTests: Total nulls: 112
• DQMHistoTests: Total successes: 3496453
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.421 KiB( 45 files compared)
• DQMHistoSizes: changed ( 10224.0 ): -0.117 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 11834.0 ): -0.591 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 250202.181 ): 0.533 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 25202.0 ): -0.246 KiB SiStrip/MechanicalView
• Checked 193 log files, 42 edm output root files, 46 DQM output files
• TriggerResults: found differences in 16 / 45 workflows

[cecilecaillol]

+l1

[tvami]

+1

• UBSAN compiles
• changes in standard CMSSW are in msg logger only

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1