Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial merge of boost io #3691

Merged
merged 14 commits into from May 10, 2014
Merged

Conversation

ktf
Copy link
Contributor

@ktf ktf commented May 6, 2014

No description provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2014

A new Pull Request was created by @ktf (Giulio Eulisse) for CMSSW_7_1_X.

Initial merge of boost io

It involves the following packages:

Alignment/CocoaDaq
Alignment/CocoaFit
Alignment/CommonAlignment
Alignment/TrackerAlignment
CondCore/CondDB
CondCore/DBOutputService
CondCore/DTPlugins
CondCore/PhysicsToolsPlugins
CondCore/PopCon
CondCore/RPCPlugins
CondCore/Utilities
CondFormats/Alignment
CondFormats/BTauObjects
CondFormats/BeamSpotObjects
CondFormats/CSCObjects
CondFormats/Calibration
CondFormats/CastorObjects
CondFormats/Common
CondFormats/DQMObjects
CondFormats/DTObjects
CondFormats/ESObjects
CondFormats/EcalCorrections
CondFormats/EcalObjects
CondFormats/EgammaObjects
CondFormats/External
CondFormats/GeometryObjects
CondFormats/HIObjects
CondFormats/HLTObjects

@perrotta, @cmsbuild, @apfeiffer1, @diguida, @danduggan, @rovere, @Martin-Grunewald, @nclopezo, @rcastello, @deguio, @fwyzard, @ggovi, @Degano, @ojeda can you please review it and eventually sign? Thanks.
@ghellwig, @pakhotin, @frmeier, @argiro, @ferencek, @mmusich, @pvmulder this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Martin-Grunewald
Copy link
Contributor

+1

@apfeiffer1
Copy link
Contributor

+1
provided Jenkins agrees ... :)

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2014

-1
I found an error when building:

class cond::SmallWORMDict
class ora::QueryableVectorcond::IOVElement
class ora::PVectorcond::IOVElement
class ora::OId
class std::pair
gmake: **\* [There are compilation/build errors. Please see the detail log above.] Error 2


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3691/1300/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2014

Pull request #3691 was updated. @perrotta, @cmsbuild, @apfeiffer1, @diguida, @danduggan, @rovere, @Martin-Grunewald, @nclopezo, @rcastello, @deguio, @fwyzard, @ggovi, @Degano, @ojeda can you please check and sign again.

@ktf
Copy link
Contributor Author

ktf commented May 9, 2014

Conflict when merging CondFormats/JetMETObjects/interface/QGLikelihoodObject.h and ak4 migration hopefully solved. @nclopezo please retest.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2014

@vadler
Copy link

vadler commented May 9, 2014

@ktf : The unit test failures are described by @slava77 in his mail to the RelOps list. It just shows up in the AT tests, where the missing collections are requested.
I'm trying a work-around (AT only, not short matrix)....

@vadler
Copy link

vadler commented May 9, 2014

@ktf : Solved with #3793 .

davidlange6 added a commit that referenced this pull request May 10, 2014
@davidlange6 davidlange6 merged commit 067ffe8 into cms-sw:CMSSW_7_1_X May 10, 2014
@apfeiffer1
Copy link
Contributor

Thanks !

On Sat, May 10, 2014 at 8:24 AM, David Lange notifications@github.comwrote:

Merged #3691 #3691.


Reply to this email directly or view it on GitHubhttps://github.com//pull/3691#event-119782515
.

Thanks,
cheers, andreas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants