Gem turn off demo unpacker - 12_2_X backport of #36769

[watson-ij]

PR description:

Backport of #36769 - turns off the GE2/1 demonstrator in the unpacker, so that upstream physics objects aren't affected by the demonstrator.

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

To make sure that GE2/1 hits aren't used in run3 reconstruction. I was going through the backports for the demonstrator geometry and saw this wasn't included in the other big changesets.

[cmsbuild]

A new Pull Request was created by @watson-ij (Ian J. Watson) for CMSSW_12_2_X.

It involves the following packages:

• EventFilter/GEMRawToDigi (reconstruction)

@jpata, @cmsbuild, @clacaputo, @slava77 can you please review it and eventually sign? Thanks.
@jshlee, @missirol, @Martin-Grunewald this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[perrotta]

urgent

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-078fde/22287/summary.html
COMMIT: 665318e
CMSSW: CMSSW_12_2_X_2022-02-08-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36910/22287/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 15 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 3252148
• DQMHistoTests: Total failures: 189
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3251936
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 41 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 177 log files, 37 edm output root files, 42 DQM output files
• TriggerResults: no differences found

[jpata]

the reco differences in e.g. PF look unexpected...

https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_12_2_X_2022-02-08-1100+078fde/48274/validateJR/all_OldVSNew_ZMM13TeV2017wf10042p0/all_OldVSNew_ZMM13TeV2017wf10042p0c_recoPFBlocks_particleFlowBlock__RECO_obj_elements_AT_size.png

I can't tell that anything went wrong in the test (e.g. something else tested concurrently), so it might need some more investigation.

[perrotta]

Indeed it is quite strange that a PR which turn off demo GEMs from the Run3 reconstruction can affect conversions in a 2017 wf...
I would say that it is completely uncorrelated, but let check if it reproduces.

[perrotta]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-078fde/22294/summary.html
COMMIT: 665318e
CMSSW: CMSSW_12_2_X_2022-02-08-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36910/22294/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 11 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 3252148
• DQMHistoTests: Total failures: 183
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3251942
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 41 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 177 log files, 37 edm output root files, 42 DQM output files
• TriggerResults: no differences found

[perrotta]

@jpata the differences in wf 10042 (ZMM 2017) are still there.
The same differences appear in the tests of an uncorrelated PR, #36900, and therefore they can't be due to this PR.
This is good for this PR, a bit worrying for the 12_2_1 release that we want to build...

[perrotta]

@slava77 the differences that we observe in the tests of wf 10042 are for the photon conversions.
I remember we already encountered intermittently in the past issues of non reproducibilities in photon conversions, but I cannot remember if they were of the same kind as these ones: can you recall if they were similar to the one observed here and in the tests of PR #36900? Was their origin finally identified?

[slava77]

@slava77 the differences that we observe in the tests of wf 10042 are for the photon conversions. I remember we already encountered intermittently in the past issues of non reproducibilities in photon conversions, but I cannot remember if they were of the same kind as these ones: can you recall if they were similar to the one observed here and in the tests of PR #36900? Was their origin finally identified?

It looks kind of familiar, but I don't have a reference to point to.
#32338 seems not the same (that was more regularly in phase2)

Looking at some older PR logs, I see that wf 25.0 occasionally had random diffs in #25741, #28089 but I don't have copies of the plots and I don't see any notes in the PRs themselves.
I don't see it in my more recent logs (since May 2020), but that may be just that I ignored those.

[perrotta]

Thank you Slava. Yes, it sounds familiar, but we can't find a reference for it.
In any case, it doesn't relate to this PR, which in my opinion should therefore proceed without caring of it.

In any case, I'll give another try with the latest IB

[perrotta]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-078fde/22297/summary.html
COMMIT: 665318e
CMSSW: CMSSW_12_2_X_2022-02-08-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36910/22297/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

The workflows 1001.0, 1000.0, 136.88811, 136.874, 136.8311, 136.793, 136.7611, 136.731, 4.22 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 3251344
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3251316
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
• Checked 177 log files, 37 edm output root files, 42 DQM output files
• TriggerResults: no differences found

[perrotta]

@cms-sw/reconstruction-l2 spurious differences have dissappeared from the comparisons wrt the latest IB, further testifying that they were not originated by this PR
If you can sign within the next 15' we can include this PR in the next IB, and start building 12_2_1 by this evening

[jpata]

+reconstruction

• direct backport of Turn off GE2/1 unpacking (demonstrator chamber) in run 3 #36769, needed for datataking
• no reco differences (none expected)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1