Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTD validation : update modules' names #36913

Merged
merged 2 commits into from Feb 9, 2022
Merged

Conversation

fabiocos
Copy link
Contributor

@fabiocos fabiocos commented Feb 8, 2022

PR description:

The name of MTD validation modules is updated by adding the suffix "Valid" to allow them to be better identified within the stack of executed plugins.

PR validation:

Test workflow 35007.0 runs succesfully.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36913/28223

  • This PR adds an extra 56KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2022

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

  • Validation/Configuration (dqm, simulation)
  • Validation/MtdValidation (dqm)

@civanch, @emanueleusai, @mdhildreth, @cmsbuild, @jfernan2, @ahmad3213, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@apsallid, @ebrondol, @rovere, @lecriste this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor Author

fabiocos commented Feb 8, 2022

please test

@fabiocos
Copy link
Contributor Author

fabiocos commented Feb 8, 2022

@gsorrentino18 FYI

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a18be1/22291/summary.html
COMMIT: e0a0008
CMSSW: CMSSW_12_3_X_2022-02-08-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36913/22291/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

The workflows 1001.0, 1000.0, 136.88811, 136.874, 136.8311, 136.793, 136.7611, 136.731, 4.22 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3765080
  • DQMHistoTests: Total failures: 14
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3765044
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 193 log files, 42 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

@fabiocos
Copy link
Contributor Author

fabiocos commented Feb 9, 2022

The failures in DQM comparison look unrelated to this PR (and I see them mentioned in other discussions in Mattermost)

@civanch
Copy link
Contributor

civanch commented Feb 9, 2022

+1

@jfernan2
Copy link
Contributor

jfernan2 commented Feb 9, 2022

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Feb 9, 2022

+1

@cmsbuild cmsbuild merged commit 755ea14 into cms-sw:master Feb 9, 2022
@fabiocos fabiocos deleted the fc-mtdvalidcfg branch February 10, 2022 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants