bug fixes for Hydjets and Pyquen #36918

wouf · 2022-02-09T14:57:10Z

PR description:

This is bugfix for #36316 . It fixes some bugs from here
Also two cff files unused in Configuration/Generator have been deleted in this PR.

PR validation:

Hydjet2 - wf 160
Hydjet - wf 150
Pyquen - wf 300

cmsbuild · 2022-02-09T15:02:51Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36918/28227

This PR adds an extra 48KB to repository

cmsbuild · 2022-02-09T15:03:10Z

A new Pull Request was created by @wouf for master.

It involves the following packages:

Configuration/Generator (generators)
GeneratorInterface/Hydjet2Interface (generators)
GeneratorInterface/HydjetInterface (generators)
GeneratorInterface/PyquenInterface (generators)

@SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @GurpreetSinghChahal, @alberto-sanchez can you please review it and eventually sign? Thanks.
@mkirsano, @cbaus, @Martin-Grunewald, @missirol, @alberto-sanchez, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

SiewYan · 2022-02-09T15:12:31Z

please test

cmsbuild · 2022-02-09T19:06:33Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-60297d/22309/summary.html
COMMIT: b8808b7
CMSSW: CMSSW_12_3_X_2022-02-09-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36918/22309/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 10 differences found in the comparisons
DQMHistoTests: Total files compared: 46
DQMHistoTests: Total histograms compared: 3765080
DQMHistoTests: Total failures: 21
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3765036
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 45 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 193 log files, 42 edm output root files, 46 DQM output files
TriggerResults: no differences found

qliphy · 2022-02-10T13:05:26Z

type bugfix

qliphy · 2022-02-10T13:05:29Z

please test workflow 148.0

perrotta · 2022-02-10T13:21:58Z

@wouf could you please write a title slightly more descriptive for this PR? At least Hydjet should be present in it

cmsbuild · 2022-02-10T17:01:03Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-60297d/22332/summary.html
COMMIT: b8808b7
CMSSW: CMSSW_12_3_X_2022-02-09-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36918/22332/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-60297d/148.0_HydjetQ_MinBias_XeXe_5442GeV_2017+HydjetQ_MinBias_XeXe_5442GeV_2017+DIGIHI2017+RECOHI2017+HARVESTHI2017

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 46
DQMHistoTests: Total histograms compared: 3764420
DQMHistoTests: Total failures: 4
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3764394
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
Checked 193 log files, 42 edm output root files, 46 DQM output files
TriggerResults: no differences found

wouf · 2022-02-11T06:07:16Z

Please hold it, the solution is not correct!

Dr15Jones · 2022-02-11T14:14:07Z

GeneratorInterface/Hydjet2Interface/src/Hydjet2Hadronizer.cc

@@ -462,6 +459,9 @@ bool Hydjet2Hadronizer::get_particles(HepMC::GenEvent *evt) {
    }
    ihy++;
  }
+  if (sub_vertices)


There is no need to check that the pointer is non-null before calling delete. Internally delete does such a check.

perrotta · 2022-02-13T11:55:00Z

urgent

cmsbuild · 2022-02-13T13:13:18Z

Pull request #36918 was updated. @SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @GurpreetSinghChahal, @alberto-sanchez can you please check and sign again.

wouf · 2022-02-15T06:28:32Z

Please hold it, the solution is not correct!

Please @wouf proceed with the correct solution, taking also into account the suggestion from Chris: wf 148.0 keeps crashing in the IBs, and we woukdn't like to propagate that crash to pre5. An acceptable (intermediate) solution could be to strip the bug fixes specific to solve the issue with that wf in a separate PR, and take your time to proceed with the other issues addressed by this PR

@perrotta This PR can be merged, I will put memory leak bugfix to other.

perrotta · 2022-02-15T06:49:12Z

@cms-sw/generators-l2 please have a look: this is needed in pre5

SiewYan · 2022-02-15T07:28:45Z

@wouf , thank for your effort. If I understood correctly, you have removed the two unused cfi and the pointer. The bugfix PR will come later?

perrotta · 2022-02-15T07:39:01Z

@wouf , thank for your effort. If I understood correctly, you have removed the two unused cfi and the pointer. The bugfix PR will come later?

@SiewYan this is THE bugfix for the crash that we observe in wf 148 in the IB, due to an int parameter being declared as a bool in a few configurations

Then, there is some possible memory leak reported by the static analyzer, and that's what differed to a future PR (unless the delete statements implemented here already solve it: I'm realizing that the bot tests were not run yet, doing it now)

perrotta · 2022-02-15T07:39:21Z

please test workflow 148.0

SiewYan · 2022-02-15T07:40:48Z

@perrotta , thank you for the description, it is very hard to follow from the long thread... I will sign it once the test is a success.

cmsbuild · 2022-02-15T12:55:39Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-60297d/22419/summary.html
COMMIT: 4ed1ac9
CMSSW: CMSSW_12_3_X_2022-02-14-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36918/22419/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-60297d/148.0_HydjetQ_MinBias_XeXe_5442GeV_2017+HydjetQ_MinBias_XeXe_5442GeV_2017+DIGIHI2017+RECOHI2017+HARVESTHI2017

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 46
DQMHistoTests: Total histograms compared: 3764435
DQMHistoTests: Total failures: 4
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3764409
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
Checked 193 log files, 42 edm output root files, 46 DQM output files
TriggerResults: no differences found

SiewYan · 2022-02-15T12:59:04Z

+1

cmsbuild · 2022-02-15T12:59:26Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2022-02-15T13:12:01Z

+1

bug fixes

b8808b7

cmsbuild added this to the CMSSW_12_3_X milestone Feb 9, 2022

cmsbuild added code-checks-pending generators-pending orp-pending pending-signatures tests-pending labels Feb 9, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 9, 2022

cmsbuild added tests-started and removed tests-pending labels Feb 9, 2022

cmsbuild added tests-approved and removed tests-started labels Feb 9, 2022

cmsbuild added bug-fix tests-started and removed tests-approved labels Feb 10, 2022

wouf changed the title ~~bug fixes~~ bug fixes for Hydjets and Pyquen Feb 10, 2022

cmsbuild added tests-approved and removed tests-started labels Feb 10, 2022

Dr15Jones reviewed Feb 11, 2022

View reviewed changes

cmsbuild added tests-started and removed tests-pending labels Feb 15, 2022

cmsbuild added tests-approved and removed tests-started labels Feb 15, 2022

cmsbuild added fully-signed generators-approved and removed generators-pending pending-signatures labels Feb 15, 2022

cmsbuild added orp-approved and removed orp-pending labels Feb 15, 2022

cmsbuild merged commit 0cd52af into cms-sw:master Feb 15, 2022

wouf deleted the from-CMSSW_12_3_X_2022-02-08-1100 branch February 24, 2022 06:03

qliphy mentioned this pull request Feb 28, 2022

memory leak fixes for Hydjets #37053

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bug fixes for Hydjets and Pyquen #36918

bug fixes for Hydjets and Pyquen #36918

wouf commented Feb 9, 2022

cmsbuild commented Feb 9, 2022

cmsbuild commented Feb 9, 2022

SiewYan commented Feb 9, 2022

cmsbuild commented Feb 9, 2022

qliphy commented Feb 10, 2022

qliphy commented Feb 10, 2022

perrotta commented Feb 10, 2022

cmsbuild commented Feb 10, 2022

wouf commented Feb 11, 2022

Dr15Jones Feb 11, 2022

perrotta commented Feb 13, 2022

cmsbuild commented Feb 13, 2022

wouf commented Feb 15, 2022

perrotta commented Feb 15, 2022

SiewYan commented Feb 15, 2022 •

edited

perrotta commented Feb 15, 2022

perrotta commented Feb 15, 2022

SiewYan commented Feb 15, 2022

cmsbuild commented Feb 15, 2022

SiewYan commented Feb 15, 2022

cmsbuild commented Feb 15, 2022

perrotta commented Feb 15, 2022

bug fixes for Hydjets and Pyquen #36918

bug fixes for Hydjets and Pyquen #36918

Conversation

wouf commented Feb 9, 2022

PR description:

PR validation:

cmsbuild commented Feb 9, 2022

cmsbuild commented Feb 9, 2022

SiewYan commented Feb 9, 2022

cmsbuild commented Feb 9, 2022

Comparison Summary

qliphy commented Feb 10, 2022

qliphy commented Feb 10, 2022

perrotta commented Feb 10, 2022

cmsbuild commented Feb 10, 2022

Comparison Summary

wouf commented Feb 11, 2022

Dr15Jones Feb 11, 2022

Choose a reason for hiding this comment

perrotta commented Feb 13, 2022

cmsbuild commented Feb 13, 2022

wouf commented Feb 15, 2022

perrotta commented Feb 15, 2022

SiewYan commented Feb 15, 2022 • edited

perrotta commented Feb 15, 2022

perrotta commented Feb 15, 2022

SiewYan commented Feb 15, 2022

cmsbuild commented Feb 15, 2022

Comparison Summary

SiewYan commented Feb 15, 2022

cmsbuild commented Feb 15, 2022

perrotta commented Feb 15, 2022

SiewYan commented Feb 15, 2022 •

edited