Use move semantics to push TrajectorySeeds into a vector #3695
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy of the 7_1_X pull request #3693 for SLHC. From that:
TrajectorySeed has a move constructor (https://github.com/cms-sw/cmssw/blob/CMSSW_6_2_X_SLHC/DataFormats/TrajectorySeed/interface/TrajectorySeed.h#L65) which previously wasn't used for the vector push.
I haven't done any benchmarking, but each individual push_back should be quite small. At 140 pileup however pixelPairStepSeeds has O(100000) of these push_backs, and that's just one of the tracking steps.