Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use move semantics to push TrajectorySeeds into a vector #3695

Merged

Conversation

mark-grimes
Copy link

Copy of the 7_1_X pull request #3693 for SLHC. From that:

TrajectorySeed has a move constructor (https://github.com/cms-sw/cmssw/blob/CMSSW_6_2_X_SLHC/DataFormats/TrajectorySeed/interface/TrajectorySeed.h#L65) which previously wasn't used for the vector push.

I haven't done any benchmarking, but each individual push_back should be quite small. At 140 pileup however pixelPairStepSeeds has O(100000) of these push_backs, and that's just one of the tracking steps.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2014

A new Pull Request was created by @mark-grimes (Mark Grimes) for CMSSW_6_2_X_SLHC.

Use move semantics to push TrajectorySeeds into a vector

It involves the following packages:

RecoTracker/TkSeedGenerator

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
@ghellwig, @GiacomoSguazzoni, @rovere, @gpetruc, @cerati, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mark-grimes
Copy link
Author

merge

Compiles fine. Trivial change so I didn't run the full set of tests, and it's been accepted for 7_1_X.

cmsbuild added a commit that referenced this pull request May 8, 2014
Use move semantics to push TrajectorySeeds into a vector
@cmsbuild cmsbuild merged commit 2189d92 into cms-sw:CMSSW_6_2_X_SLHC May 8, 2014
@mark-grimes mark-grimes deleted the moveTrajectorySeedSLHC branch August 3, 2015 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants