New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make some L1Trigger config static pointers thread safe #36965
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36965/28328
|
A new Pull Request was created by @dan131riley (Dan Riley) for master. It involves the following packages:
@epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+l1 |
please test |
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2493e2/22420/summary.html Comparison SummarySummary:
|
+1 |
PR description:
UBSAN IBs identified some thread-unsafe initialization and destruction of static pointers used for config and debug information. These produced runtime errors like:
followed by segmentation violations. This PR replaces the thread-unsafe initialization and destruction of the static pointers with thread-safe manipulations of
std::shared_ptr
.PR validation:
Ran WF 139.002 in CMSSW_12_3_UBSAN_X_2022-02-11-1100 and verified that no null pointer derefs were seen and no new errors appeared. Purely technical fix, should have no impact on performance.