New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix HPTDC timing PCL #36976
Fix HPTDC timing PCL #36976
Conversation
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36976/28344
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
f453b7f
to
84472ca
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36976/28345
|
A new Pull Request was created by @ChrisMisan (Christopher) for master. It involves the following packages:
@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
test parameters:
|
@cmsbuild , please test |
type bug-fix |
ddc905f
to
62eaba7
Compare
Sorry, @tvami can you restart the tests after the code-checks? |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36976/28346
|
@cmsbuild , please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e2cf7a/22446/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
urgent
|
+1
|
PR description:
PR aims to fix timing PCL. Current Harvester is unable to receive any data from the workers.
Changes:
-relative paths were changed to absolute
-Incorrect histogram type was corrected
-Incorrect EdmToMeConverter configuration was fixed
PR validation:
Relval 1041
if this PR is a backport please specify the original PR and why you need to backport that PR:
no