small improvements to HLTSumJetTag

[missirol]

PR description:

This PR provides small improvements to the HLT filters introduced in #36862 (cc: @rgerosa), including a follow-up to the review comments in #36862 (review).

One change is not merely technical; it concerns the case where MatchByDeltaR == true. In the original implementation, every jet is assigned a "jetTag" value, and, when there is no valid Delta-R match with a jet in the JetTag map, then the tagValue is set to an arbitrary -1000. In this PR, jets without a valid DR-match are instead skipped; for realistic cuts on "JetSumTag", the two approaches should be equivalent from a practical point of view, and I would suggest to use the one in this PR.

Since the relevant plugins are not run in any central wf, the PR tests are not expected to be sensitive to this PR.

PR validation:

I manually checked with the recipe provided in cms-data/RecoBTag-Combined#47 (comment) (plus some edits to the config file, using one instance of the plugin with MatchByDeltaR=false and one with MatchByDeltaR=true) that the results of the HLT filters, and corresponding trigger objects, are exactly the same for 100 MC events.

If this PR is a backport, please specify the original PR and why you need to backport that PR:

N/A

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36981/28357

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @missirol (Marino Missiroli) for master.

It involves the following packages:

• HLTrigger/btau (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@AlexDeMoor, @emilbols, @silviodonato, @Martin-Grunewald, @JyothsnaKomaragiri, @andrzejnovak, @demuller this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[missirol]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b27ec4/22466/summary.html
COMMIT: bd80a79
CMSSW: CMSSW_12_3_X_2022-02-16-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36981/22466/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-b27ec4/138.4_PromptCollisions+RunMinimumBias2021+ALCARECOPROMPTR3+HARVESTDPROMPTR3
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-b27ec4/138.5_ExpressCollisions+RunMinimumBias2021+TIER0EXPRUN3+ALCARECOEXPR3+HARVESTDEXPR3
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-b27ec4/139.001_RunMinimumBias2021+RunMinimumBias2021+HLTDR3_2021+RECODR3_MinBiasOffline+HARVESTD2021MB

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3965143
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3965113
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 204 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[missirol]

+hlt

• small improvements to a HLT filter not presently used in any central wf

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1