Fix thread-safety issue in PrimaryVertexGenerator #3702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The static analyzer found that PrimaryVertexGenerator was return a non-const pointer to its internal data from a const function. This was changed to returning a const pointer and a non-const function was added which returned the non-const pointer.
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_1_X. Fix thread-safety issue in PrimaryVertexGenerator It involves the following packages: FastSimulation/Event @cmsbuild, @Degano, @giamman, @lveldere, @nclopezo can you please review it and eventually sign? Thanks. |
|
+1 |
davidlange6
added a commit
that referenced
this pull request
May 7, 2014
Fix thread-safety issue in PrimaryVertexGenerator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The static analyzer found that PrimaryVertexGenerator was return
a non-const pointer to its internal data from a const function. This
was changed to returning a const pointer and a non-const function was
added which returned the non-const pointer.