Add energy units to CMSUnits.h

[cvuosalo]

DataFormats/Math/interface/GeantUnits.h contains energy units, but DataFormats/Math/interface/CMSUnits.h didn't have them. For consistency, the units _eV, _MeV, _GeV, and _TeV are added to CMSUnits.h, along with enegy conversion functions. The definitions of the conversion functions were moved to DataFormats/Math/interface/angle_units.h to avoid code duplication. angle_units.h is not an ideal location for energy and length conversion functions, but such simple functions don't really justify the creation of a new header file to hold them.

This PR resolves issue #29750.

PR validation:

The new units were added to a test program, and it successfully compiled.

No backport is needed.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37037/28468

• This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37037/28468/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37037/28468/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37037/28470

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @cvuosalo (Carl Vuosalo) for master.

It involves the following packages:

• DataFormats/Math (reconstruction)

@jpata, @cmsbuild, @clacaputo, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @fabiocos, @rovere this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cvuosalo]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6d0df4/22595/summary.html
COMMIT: ca206ea
CMSSW: CMSSW_12_3_X_2022-02-22-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37037/22595/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3965143
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3965119
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 204 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[jpata]

+reconstruction

• technical
• it doesn't look like CMSUnits.h is used by reco anywhere

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1