Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase2-gem67 Small cleanup of a test analyzer in Geometry/GEMGeometry #37047

Merged
merged 2 commits into from Feb 26, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
19 changes: 8 additions & 11 deletions Geometry/GEMGeometry/test/GEMDetIdAnalyzer.cc
Expand Up @@ -32,15 +32,14 @@ class GEMDetIdAnalyzer : public edm::one::EDAnalyzer<edm::one::WatchRuns> {
void endRun(edm::Run const&, edm::EventSetup const&) override {}

private:
edm::EDGetToken gemRecHit_, me0RecHit_;
bool newGEM_;
const edm::EDGetToken gemRecHit_, me0RecHit_;
const bool newGEM_;
};

GEMDetIdAnalyzer::GEMDetIdAnalyzer(const edm::ParameterSet& iConfig) {
gemRecHit_ = consumes<GEMRecHitCollection>(iConfig.getParameter<edm::InputTag>("gemInputLabel"));
me0RecHit_ = consumes<ME0RecHitCollection>(iConfig.getParameter<edm::InputTag>("me0InputLabel"));
newGEM_ = iConfig.getParameter<bool>("newGEMDetID");
}
GEMDetIdAnalyzer::GEMDetIdAnalyzer(const edm::ParameterSet& iConfig)
: gemRecHit_(consumes<GEMRecHitCollection>(iConfig.getParameter<edm::InputTag>("gemInputLabel"))),
me0RecHit_(consumes<ME0RecHitCollection>(iConfig.getParameter<edm::InputTag>("me0InputLabel"))),
newGEM_(iConfig.getParameter<bool>("newGEMDetID")) {}

void GEMDetIdAnalyzer::fillDescriptions(edm::ConfigurationDescriptions& descriptions) {
edm::ParameterSetDescription desc;
Expand All @@ -51,8 +50,7 @@ void GEMDetIdAnalyzer::fillDescriptions(edm::ConfigurationDescriptions& descript
}

void GEMDetIdAnalyzer::analyze(edm::Event const& iEvent, edm::EventSetup const& iSetup) {
edm::Handle<GEMRecHitCollection> gemRecHits;
iEvent.getByToken(gemRecHit_, gemRecHits);
const edm::Handle<GEMRecHitCollection>& gemRecHits = iEvent.getHandle(gemRecHit_);
if (!gemRecHits.isValid()) {
edm::LogError("GEMAnalysis") << "GEM RecHit is not valid";
} else {
Expand All @@ -65,8 +63,7 @@ void GEMDetIdAnalyzer::analyze(edm::Event const& iEvent, edm::EventSetup const&
}
}

edm::Handle<ME0RecHitCollection> me0RecHits;
iEvent.getByToken(me0RecHit_, me0RecHits);
const edm::Handle<ME0RecHitCollection>& me0RecHits = iEvent.getHandle(me0RecHit_);
if (!me0RecHits.isValid()) {
edm::LogError("GEMAnalysis") << "ME0 RecHit is not valid";
} else {
Expand Down