Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PPSAlCaRecoProducer - minor fixes requested in #36273 #37048

Merged
merged 3 commits into from Feb 23, 2022

Conversation

MatiXOfficial
Copy link
Contributor

PR description:

This PR fixes the minor issues from the discussion in #36273. The changes are listed below.

  • Replaced cms.InputTag with regular strings (inside clone) in ALCARECOPPSCalMaxTracks_cff.py.
  • Deleted hlt_out_singleRAW.py and setup_dev_CMSSW_12_1_0_GRun_V14_cff.py. They were not necessary for the unit tests in the test folder.
  • Deleted hltEventAnalyzerAOD from the prompt_PPSAlCaReco_output test. It was not necessary for that test and made the output verbose. Also, there are no 0 accepted 'L3' objects found messages anymore.

PR validation:

  • The unit tests pass.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37048/28483

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @MatiXOfficial (Mateusz Kocot) for master.

It involves the following packages:

  • Calibration/PPSAlCaRecoProducer (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor

tvami commented Feb 23, 2022

@MatiXOfficial thanks for this, can you please modify the title to be a bit more specific?

@tvami
Copy link
Contributor

tvami commented Feb 23, 2022

test parameters:

  • workflows = 1041, 1042

@tvami
Copy link
Contributor

tvami commented Feb 23, 2022

@cmsbuild , please test

@MatiXOfficial MatiXOfficial changed the title PPSAlCaRecoProducer fixes PPSAlCaRecoProducer - minor fixes requested in #36273 Feb 23, 2022
@MatiXOfficial
Copy link
Contributor Author

@MatiXOfficial thanks for this, can you please modify the title to be a bit more specific?

@tvami I hope it's better now :)

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-74f54d/22619/summary.html
COMMIT: 132d1a8
CMSSW: CMSSW_12_3_X_2022-02-23-0800/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37048/22619/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-74f54d/1041.0_RunExpressPhy2017F+RunExpressPhy2017F+TIER0EXPPPSCAL+ALCASPLITPPSCAL+ALCAHARVDPPSCAL
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-74f54d/1042.0_RunExpressPhy2017F+RunExpressPhy2017F+TIER0EXPPPSCALALIG+ALCASPLITPPSALIG+ALCAHARVDPPSALIG

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 4001143
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 4001107
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Feb 23, 2022

+alca

  • fixes from prev request
  • no diffs in the Jenkins are found

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 9bed8b9 into cms-sw:master Feb 23, 2022
@MatiXOfficial MatiXOfficial deleted the pps_alcarecoproducer_fixes branch February 24, 2022 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants