New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PPSAlCaRecoProducer - minor fixes requested in #36273 #37048
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37048/28483
|
A new Pull Request was created by @MatiXOfficial (Mateusz Kocot) for master. It involves the following packages:
@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@MatiXOfficial thanks for this, can you please modify the title to be a bit more specific? |
test parameters:
|
@cmsbuild , please test |
@tvami I hope it's better now :) |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-74f54d/22619/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
+alca
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR fixes the minor issues from the discussion in #36273. The changes are listed below.
cms.InputTag
with regular strings (insideclone
) inALCARECOPPSCalMaxTracks_cff.py
.hlt_out_singleRAW.py
andsetup_dev_CMSSW_12_1_0_GRun_V14_cff.py
. They were not necessary for the unit tests in thetest
folder.hltEventAnalyzerAOD
from theprompt_PPSAlCaReco_output
test. It was not necessary for that test and made the output verbose. Also, there are no0 accepted 'L3' objects found
messages anymore.PR validation: