Updated the PPS PCL workers to support the new AlCaRecoProducer #37050

MatiXOfficial · 2022-02-23T16:22:49Z

PR description:

This PR modifies the way the PCL workers (alignment, timing, sampic timing) handle consuming input products. Single InputTags have been replaced with vectors of InputTags so that the workers could work both with the old producer and with the new producer introduced in #36273.

By default, the behaviour of the workers is unchanged - the vectors contain only one element. The PCL configs modify these vectors to contain the InputTags required by the new producer as well.

In the case of the timing PCLs, the re-reconstruction of the recHits was dropped, and the old producer was modified to supply the recHits directly. It shouldn't cause any change in terms of the produced results.

PR validation:

no changes in the relvals (1041, 1042)
no changes in the results of some local tests
The multi-InputTag policy works as expected - the PCL workers accept the files produced by the old producer and the files produced by the new producer.

cmsbuild · 2022-02-23T16:30:03Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37050/28487

This PR adds an extra 20KB to repository

cmsbuild · 2022-02-23T16:30:26Z

A new Pull Request was created by @MatiXOfficial (Mateusz Kocot) for master.

It involves the following packages:

CalibPPS/AlignmentGlobal (alca)
CalibPPS/TimingCalibration (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@fabferro, @mmusich, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

tvami · 2022-02-23T16:43:52Z

test parameters:

workflows = 1041, 1042

CalibPPS/AlignmentGlobal/plugins/PPSAlignmentWorker.cc

CalibPPS/TimingCalibration/plugins/PPSDiamondSampicTimingCalibrationPCLWorker.cc

CalibPPS/TimingCalibration/plugins/PPSTimingCalibrationPCLWorker.cc

cmsbuild · 2022-02-23T17:44:03Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37050/28489

This PR adds an extra 20KB to repository

cmsbuild · 2022-02-23T17:44:28Z

Pull request #37050 was updated. @cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please check and sign again.

tvami · 2022-02-23T18:19:48Z

@cmsbuild , please test

cmsbuild · 2022-02-23T20:21:36Z

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-975475/22626/summary.html
COMMIT: aa32bcf
CMSSW: CMSSW_12_3_X_2022-02-23-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37050/22626/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

1325.81

----- Begin Fatal Exception 23-Feb-2022 19:23:28 UTC-----------------------
An exception of category 'FileReadError' occurred while
   [0] Processing  Event run: 1 lumi: 19 event: 901 stream: 0
   [1] Running path 'nanoAOD_step'
   [2] Prefetching for module GenMETExtractor/'genMetExtractor'
   [3] While reading from source std::vector<pat::MET> slimmedMETs '' RECO
   [4] Rethrowing an exception that happened on a different read request.
   [5] Processing  Event run: 1 lumi: 19 event: 901 stream: 0
   [6] Running path 'dqmoffline_step'
   [7] Prefetching for module NanoAODDQM/'nanoDQMMC'
   [8] Prefetching for module TriggerObjectTableProducer/'triggerObjectTable'
   [9] While reading from source BXVector<l1t::Tau> caloStage2Digis 'Tau' RECO
   [10] Rethrowing an exception that happened on a different read request.
   [11] Processing  Event run: 1 lumi: 19 event: 901 stream: 0
   [12] Running path 'dqmoffline_step'
   [13] Prefetching for module NanoAODDQM/'nanoDQMMC'
   [14] Prefetching for module TriggerObjectTableProducer/'triggerObjectTable'
   [15] While reading from source BXVector<l1t::Muon> gmtStage2Digis 'Muon' RECO
   [16] Rethrowing an exception that happened on a different read request.
   [17] Processing  Event run: 1 lumi: 19 event: 901 stream: 0
   [18] Running path 'dqmoffline_step'
   [19] Prefetching for module NanoAODDQM/'nanoDQMMC'
   [20] Prefetching for module TriggerObjectTableProducer/'triggerObjectTable'
   [21] While reading from source BXVector<l1t::Jet> caloStage2Digis 'Jet' RECO
   [22] Rethrowing an exception that happened on a different read request.
   [23] Processing  Event run: 1 lumi: 19 event: 901 stream: 0
   [24] Running path 'dqmoffline_step'
   [25] Prefetching for module NanoAODDQM/'nanoDQMMC'
   [26] Prefetching for module TriggerObjectTableProducer/'triggerObjectTable'
   [27] While reading from source BXVector<l1t::EtSum> caloStage2Digis 'EtSum' RECO
   [28] Rethrowing an exception that happened on a different read request.
   [29] Processing  Event run: 1 lumi: 19 event: 901 stream: 0
   [30] Running path 'dqmoffline_step'
   [31] Prefetching for module NanoAODDQM/'nanoDQMMC'
   [32] Prefetching for module TriggerObjectTableProducer/'triggerObjectTable'
   [33] While reading from source BXVector<l1t::EGamma> caloStage2Digis 'EGamma' RECO
   [34] Rethrowing an exception that happened on a different read request.
   [35] Processing  Event run: 1 lumi: 19 event: 901 stream: 0
   [36] Running path 'dqmoffline_step'
   [37] Prefetching for module NanoAODDQM/'nanoDQMMC'
   [38] Prefetching for module TriggerObjectTableProducer/'triggerObjectTable'
   [39] Prefetching for module PATTriggerObjectStandAloneUnpacker/'unpackedPatTrigger'
   [40] While reading from source edm::TriggerResults TriggerResults '' HLT
   [41] Rethrowing an exception that happened on a different read request.
   [42] Processing  Event run: 1 lumi: 19 event: 901 stream: 0
   [43] Running path 'dqmoffline_step'
   [44] Prefetching for module NanoAODDQM/'nanoDQMMC'
   [45] Prefetching for module TriggerObjectTableProducer/'triggerObjectTable'
   [46] Prefetching for module PATTriggerObjectStandAloneUnpacker/'unpackedPatTrigger'
   [47] While reading from source std::vector<pat::TriggerObjectStandAlone> slimmedPatTrigger '' RECO
   [48] Rethrowing an exception that happened on a different read request.
   [49] Processing  Event run: 1 lumi: 19 event: 901 stream: 0
   [50] Running path 'dqmoffline_step'
   [51] Prefetching for module NanoAODDQM/'nanoDQMMC'
   [52] Prefetching for module SimpleCandidateFlatTableProducer/'svCandidateTable'
   [53] Prefetching for module VertexTableProducer/'vertexTable'
   [54] While reading from source edm::ValueMap<float> offlineSlimmedPrimaryVertices '' RECO
   [55] Rethrowing an exception that happened on a different read request.
   [56] Processing  Event run: 1 lumi: 19 event: 901 stream: 0
   [57] Running path 'dqmoffline_step'
   [58] Prefetching for module NanoAODDQM/'nanoDQMMC'
   [59] Prefetching for module SimpleCandidateFlatTableProducer/'subJetTable'
   [60] While reading from source std::vector<pat::Jet> slimmedJetsAK8PFPuppiSoftDropPacked 'SubJets' RECO
   [61] Rethrowing an exception that happened on a different read request.
   [62] Processing  Event run: 1 lumi: 19 event: 901 stream: 0
   [63] Running path 'dqmoffline_step'
   [64] Prefetching for module NanoAODDQM/'nanoDQMMC'
   [65] Prefetching for module GlobalVariablesTableProducer/'rhoTable'
   [66] While reading from source double fixedGridRhoFastjetCentralNeutral '' RECO
   [67] Rethrowing an exception that happened on a different read request.
   [68] Processing  Event run: 1 lumi: 19 event: 901 stream: 0
   [69] Running path 'dqmoffline_step'
   [70] Prefetching for module NanoAODDQM/'nanoDQMMC'
   [71] Prefetching for module GlobalVariablesTableProducer/'rhoTable'
   [72] While reading from source double fixedGridRhoFastjetCentralChargedPileUp '' RECO
   [73] Rethrowing an exception that happened on a different read request.
   [74] Processing  Event run: 1 lumi: 19 event: 901 stream: 0
   [75] Running path 'dqmoffline_step'
   [76] Prefetching for module NanoAODDQM/'nanoDQMMC'
   [77] Prefetching for module GlobalVariablesTableProducer/'rhoTable'
   [78] While reading from source double fixedGridRhoFastjetCentralCalo '' RECO
   [79] Rethrowing an exception that happened on a different read request.
   [80] Processing  Event run: 1 lumi: 19 event: 901 stream: 0
   [81] Running path 'dqmoffline_step'
   [82] Prefetching for module NanoAODDQM/'nanoDQMMC'
   [83] Prefetching for module GlobalVariablesTableProducer/'rhoTable'
   [84] While reading from source double fixedGridRhoFastjetCentral '' RECO
   [85] Rethrowing an exception that happened on a different read request.
   [86] Processing  Event run: 1 lumi: 19 event: 901 stream: 0
   [87] Running path 'dqmoffline_step'
   [88] Prefetching for module NanoAODDQM/'nanoDQMMC'
   [89] Prefetching for module NPUTablesProducer/'puTable'
   [90] While reading from source std::vector<PileupSummaryInfo> slimmedAddPileupInfo '' RECO
   [91] Rethrowing an exception that happened on a different read request.
   [92] Processing  Event run: 1 lumi: 19 event: 901 stream: 0
   [93] Running path 'dqmoffline_step'
   [94] Prefetching for module NanoAODDQM/'nanoDQMMC'
   [95] Prefetching for module SimpleCandidateFlatTableProducer/'isoTrackTable'
   [96] Prefetching for module IsFromLostTrackMapProducer/'isFromLostTrackForIsoTk'
   [97] While reading from source std::vector<pat::PackedCandidate> lostTracks '' RECO
   [98] Rethrowing an exception that happened on a different read request.
   [99] Processing  Event run: 1 lumi: 19 event: 901 stream: 0
   [100] Running path 'dqmoffline_step'
   [101] Prefetching for module NanoAODDQM/'nanoDQMMC'
   [102] Prefetching for module SimpleCandidateFlatTableProducer/'isoTrackTable'
   [103] Prefetching for module IsolatedTrackCleaner/'finalIsolatedTracks'
   [104] While reading from source std::vector<pat::IsolatedTrack> isolatedTracks '' RECO
   [105] Rethrowing an exception that happened on a different read request.
   [106] Processing  Event run: 1 lumi: 19 event: 901 stream: 0
   [107] Running path 'dqmoffline_step'
   [108] Prefetching for module NanoAODDQM/'nanoDQMMC'
   [109] Prefetching for module SimpleXYZPointFlatTableProducer/'genVertexTable'
   [110] While reading from source ROOT::Math::PositionVector3D<ROOT::Math::Cartesian3D<float>,ROOT::Math::DefaultCoordinateSystemTag> genParticles 'xyz0' HLT
   [111] Rethrowing an exception that happened on a different read request.
   [112] Processing  Event run: 1 lumi: 19 event: 901 stream: 0
   [113] Running path 'dqmoffline_step'
   [114] Prefetching for module NanoAODDQM/'nanoDQMMC'
   [115] Prefetching for module GlobalVariablesTableProducer/'genVertexT0Table'
   [116] While reading from source float genParticles 't0' HLT
   [117] Rethrowing an exception that happened on a different read request.
   [118] Processing  Event run: 1 lumi: 19 event: 901 stream: 0
   [119] Running path 'dqmoffline_step'
   [120] Prefetching for module NanoAODDQM/'nanoDQMMC'
   [121] Prefetching for module SimpleCandidateFlatTableProducer/'genSubJetAK8Table'
   [122] While reading from source std::vector<reco::GenJet> slimmedGenJetsAK8SoftDropSubJets '' RECO
   [123] Rethrowing an exception that happened on a different read request.
   [124] Processing  Event run: 1 lumi: 19 event: 901 stream: 0
   [125] Running path 'dqmoffline_step'
   [126] Prefetching for module NanoAODDQM/'nanoDQMMC'
   [127] Prefetching for module GenProtonTableProducer/'genProtonTable'
   [128] While reading from source std::vector<reco::GenParticle> genPUProtons '' HLT
   [129] Rethrowing an exception that happened on a different read request.
   [130] Processing  Event run: 1 lumi: 19 event: 901 stream: 0
   [131] Running path 'dqmoffline_step'
   [132] Prefetching for module NanoAODDQM/'nanoDQMMC'
   [133] Prefetching for module GenJetFlavourTableProducer/'genJetFlavourTable'
   [134] While reading from source reco::JetFlavourInfoMatchingCollection slimmedGenJetsFlavourInfos '' RECO
   [135] Rethrowing an exception that happened on a different read request.
   [136] Processing  Event run: 1 lumi: 19 event: 901 stream: 0
   [137] Running path 'dqmoffline_step'
   [138] Prefetching for module NanoAODDQM/'nanoDQMMC'
   [139] Prefetching for module GenJetFlavourTableProducer/'genJetFlavourTable'
   [140] While reading from source std::vector<reco::GenJet> slimmedGenJets '' RECO
   [141] Rethrowing an exception that happened on a different read request.
   [142] Processing  Event run: 1 lumi: 19 event: 901 stream: 0
   [143] Running path 'dqmoffline_step'
   [144] Prefetching for module NanoAODDQM/'nanoDQMMC'
   [145] Prefetching for module GenJetFlavourTableProducer/'genJetAK8FlavourTable'
   [146] While reading from source std::vector<reco::GenJet> slimmedGenJetsAK8 '' RECO
   [147] Rethrowing an exception that happened on a different read request.
   [148] Processing  Event run: 1 lumi: 19 event: 901 stream: 0
   [149] Running path 'dqmoffline_step'
   [150] Prefetching for module NanoAODDQM/'nanoDQMMC'
   [151] Prefetching for module SimpleCandidateFlatTableProducer/'fatJetMCTable'
   [152] Prefetching for module PATJetRefSelector/'finalJetsAK8'
   [153] Prefetching for module PATJetUserDataEmbedder/'updatedJetsAK8WithUserData'
   [154] Prefetching for module PATJetUpdater/'updatedJetsAK8'
   [155] Prefetching for module PATJetSelector/'selectedUpdatedPatJetsAK8WithDeepInfo'
   [156] Prefetching for module PATJetUpdater/'updatedPatJetsTransientCorrectedAK8WithDeepInfo'
   [157] Prefetching for module PATJetUpdater/'updatedPatJetsAK8WithDeepInfo'
   [158] While reading from source std::vector<pat::Jet> slimmedJetsAK8 '' RECO
   [159] Rethrowing an exception that happened on a different read request.
   [160] Processing  Event run: 1 lumi: 19 event: 901 stream: 0
   [161] Running path 'dqmoffline_step'
   [162] Prefetching for module NanoAODDQM/'nanoDQMMC'
   [163] Prefetching for module BTagSFProducer/'btagWeightTable'
   [164] Prefetching for module PATObjectCrossLinker/'linkedObjects'
   [165] Prefetching for module PATPhotonRefSelector/'finalPhotons'
   [166] Prefetching for module PATPhotonUserDataEmbedder/'slimmedPhotonsWithUserData'
   [167] While reading from source std::vector<pat::Photon> slimmedPhotons '' RECO
   [168] Rethrowing an exception that happened on a different read request.
   [169] Processing  Event run: 1 lumi: 19 event: 901 stream: 0
   [170] Running path 'dqmoffline_step'
   [171] Prefetching for module NanoAODDQM/'nanoDQMMC'
   [172] Prefetching for module BTagSFProducer/'btagWeightTable'
   [173] Prefetching for module PATObjectCrossLinker/'linkedObjects'
   [174] Prefetching for module PATTauRefSelector/'finalTaus'
   [175] Prefetching for module PATTauIDEmbedder/'slimmedTausUpdated'
   [176] While reading from source std::vector<pat::Tau> slimmedTaus '' RECO
   [177] Rethrowing an exception that happened on a different read request.
   [178] Processing  Event run: 1 lumi: 19 event: 901 stream: 0
   [179] Running path 'dqmoffline_step'
   [180] Prefetching for module NanoAODDQM/'nanoDQMMC'
   [181] Prefetching for module BTagSFProducer/'btagWeightTable'
   [182] Prefetching for module PATObjectCrossLinker/'linkedObjects'
   [183] Prefetching for module PATElectronRefSelector/'finalElectrons'
   [184] Prefetching for module PATElectronUserDataEmbedder/'slimmedElectronsWithUserData'
   [185] Prefetching for module EleVIDNestedWPBitmapProducer/'bitmapVIDForEle'
   [186] Prefetching for module VersionedGsfElectronIdProducer/'egmGsfElectronIDs'
   [187] While reading from source std::vector<reco::Conversion> reducedEgamma 'reducedConversions' RECO
   [188] Rethrowing an exception that happened on a different read request.
   [189] Processing  Event run: 1 lumi: 19 event: 901 stream: 0
   [190] Running path 'dqmoffline_step'
   [191] Prefetching for module NanoAODDQM/'nanoDQMMC'
   [192] Prefetching for module BTagSFProducer/'btagWeightTable'
   [193] Prefetching for module PATObjectCrossLinker/'linkedObjects'
   [194] Prefetching for module PATElectronRefSelector/'finalElectrons'
   [195] Prefetching for module PATElectronUserDataEmbedder/'slimmedElectronsWithUserData'
   [196] Prefetching for module ElectronMVAValueMapProducer/'electronMVAValueMapProducer'
   [197] While reading from source double fixedGridRhoAll '' RECO
   [198] Rethrowing an exception that happened on a different read request.
   [199] Processing  Event run: 1 lumi: 19 event: 901 stream: 0
   [200] Running path 'dqmoffline_step'
   [201] Prefetching for module NanoAODDQM/'nanoDQMMC'
   [202] Prefetching for module BTagSFProducer/'btagWeightTable'
   [203] Prefetching for module PATObjectCrossLinker/'linkedObjects'
   [204] Prefetching for module PATElectronRefSelector/'finalElectrons'
   [205] Prefetching for module PATElectronUserDataEmbedder/'slimmedElectronsWithUserData'
   [206] Prefetching for module CalibratedPatElectronProducer/'calibratedPatElectronsNano'
   [207] While reading from source edm::SortedCollection<EcalRecHit,edm::StrictWeakOrdering<EcalRecHit> > reducedEgamma 'reducedEERecHits' RECO
   [208] Rethrowing an exception that happened on a different read request.
   [209] Processing  Event run: 1 lumi: 19 event: 901 stream: 0
   [210] Running path 'dqmoffline_step'
   [211] Prefetching for module NanoAODDQM/'nanoDQMMC'
   [212] Prefetching for module BTagSFProducer/'btagWeightTable'
   [213] Prefetching for module PATObjectCrossLinker/'linkedObjects'
   [214] Prefetching for module PATElectronRefSelector/'finalElectrons'
   [215] Prefetching for module PATElectronUserDataEmbedder/'slimmedElectronsWithUserData'
   [216] Prefetching for module CalibratedPatElectronProducer/'calibratedPatElectronsNano'
   [217] While reading from source edm::SortedCollection<EcalRecHit,edm::StrictWeakOrdering<EcalRecHit> > reducedEgamma 'reducedEBRecHits' RECO
   [218] Rethrowing an exception that happened on a different read request.
   [219] Processing  Event run: 1 lumi: 19 event: 901 stream: 0
   [220] Running path 'dqmoffline_step'
   [221] Prefetching for module NanoAODDQM/'nanoDQMMC'
   [222] Prefetching for module BTagSFProducer/'btagWeightTable'
   [223] Prefetching for module PATObjectCrossLinker/'linkedObjects'
   [224] Prefetching for module PATElectronRefSelector/'finalElectrons'
   [225] Prefetching for module PATElectronUserDataEmbedder/'slimmedElectronsWithUserData'
   [226] Prefetching for module PATElectronUpdater/'slimmedElectronsUpdated'
   [227] While reading from source std::vector<pat::Electron> slimmedElectrons '' RECO
   [228] Rethrowing an exception that happened on a different read request.
   [229] Processing  Event run: 1 lumi: 19 event: 901 stream: 0
   [230] Running path 'dqmoffline_step'
   [231] Prefetching for module NanoAODDQM/'nanoDQMMC'
   [232] Prefetching for module BTagSFProducer/'btagWeightTable'
   [233] Prefetching for module PATObjectCrossLinker/'linkedObjects'
   [234] Prefetching for module PATMuonRefSelector/'finalMuons'
   [235] Prefetching for module PATMuonUserDataEmbedder/'slimmedMuonsWithUserData'
   [236] Prefetching for module PATMuonUpdater/'slimmedMuonsUpdated'
   [237] While reading from source std::vector<pat::Muon> slimmedMuons '' RECO
   [238] Rethrowing an exception that happened on a different read request.
   [239] Processing  Event run: 1 lumi: 19 event: 901 stream: 0
   [240] Running path 'dqmoffline_step'
   [241] Prefetching for module NanoAODDQM/'nanoDQMMC'
   [242] Prefetching for module BTagSFProducer/'btagWeightTable'
   [243] Prefetching for module PATObjectCrossLinker/'linkedObjects'
   [244] Prefetching for module PATJetRefSelector/'finalJets'
   [245] Prefetching for module PATJetUserDataEmbedder/'updatedJetsWithUserData'
   [246] Prefetching for module JetRegressionVarProducer/'bJetVars'
   [247] While reading from source std::vector<reco::VertexCompositePtrCandidate> slimmedSecondaryVertices '' RECO
   [248] Rethrowing an exception that happened on a different read request.
   [249] Processing  Event run: 1 lumi: 19 event: 901 stream: 0
   [250] Running path 'dqmoffline_step'
   [251] Prefetching for module NanoAODDQM/'nanoDQMMC'
   [252] Prefetching for module BTagSFProducer/'btagWeightTable'
   [253] Prefetching for module PATObjectCrossLinker/'linkedObjects'
   [254] Prefetching for module PATJetRefSelector/'finalJets'
   [255] Prefetching for module PATJetUserDataEmbedder/'updatedJetsWithUserData'
   [256] Prefetching for module BetaStarPackedCandidateVarProducer/'jercVars'
   [257] While reading from source std::vector<pat::PackedCandidate> packedPFCandidates '' RECO
   [258] Rethrowing an exception that happened on a different read request.
   [259] Processing  Event run: 1 lumi: 19 event: 901 stream: 0
   [260] Running path 'dqmoffline_step'
   [261] Prefetching for module NanoAODDQM/'nanoDQMMC'
   [262] Prefetching for module BTagSFProducer/'btagWeightTable'
   [263] Prefetching for module PATObjectCrossLinker/'linkedObjects'
   [264] Prefetching for module PATJetRefSelector/'finalJets'
   [265] Prefetching for module PATJetUserDataEmbedder/'updatedJetsWithUserData'
   [266] Prefetching for module PATJetUpdater/'updatedJets'
   [267] Prefetching for module JetCorrFactorsProducer/'jetCorrFactorsNano'
   [268] While reading from source double fixedGridRhoFastjetAll '' RECO
   [269] Rethrowing an exception that happened on a different read request.
   [270] Processing  Event run: 1 lumi: 19 event: 901 stream: 0
   [271] Running path 'dqmoffline_step'
   [272] Prefetching for module NanoAODDQM/'nanoDQMMC'
   [273] Prefetching for module BTagSFProducer/'btagWeightTable'
   [274] Prefetching for module PATObjectCrossLinker/'linkedObjects'
   [275] Prefetching for module PATJetRefSelector/'finalJets'
   [276] Prefetching for module PATJetUserDataEmbedder/'updatedJetsWithUserData'
   [277] Prefetching for module PATJetUpdater/'updatedJets'
   [278] Prefetching for module JetCorrFactorsProducer/'jetCorrFactorsNano'
   [279] While reading from source std::vector<reco::Vertex> offlineSlimmedPrimaryVertices '' RECO
   [280] Rethrowing an exception that happened on a different read request.
   [281] Processing  Event run: 1 lumi: 19 event: 901 stream: 0
   [282] Running path 'dqmoffline_step'
   [283] Prefetching for module NanoAODDQM/'nanoDQMMC'
   [284] Prefetching for module BTagSFProducer/'btagWeightTable'
   [285] Prefetching for module PATObjectCrossLinker/'linkedObjects'
   [286] Prefetching for module PATJetRefSelector/'finalJets'
   [287] Prefetching for module PATJetUserDataEmbedder/'updatedJetsWithUserData'
   [288] Prefetching for module PATJetUpdater/'updatedJets'
   [289] While reading from source std::vector<pat::Jet> slimmedJets '' RECO
   [290] Rethrowing an exception that happened on a different read request.
   [291] Processing  Event run: 1 lumi: 19 event: 901 stream: 0
   [292] Running path 'dqmoffline_step'
   [293] Prefetching for module NanoAODDQM/'nanoDQMMC'
   [294] Prefetching for module SimpleBeamspotFlatTableProducer/'beamSpotTable'
   [295] While reading from source reco::BeamSpot offlineBeamSpot '' RECO
   [296] Rethrowing an exception that happened on a different read request.
   [297] Processing  Event run: 1 lumi: 19 event: 901 stream: 0
   [298] Running path 'dqmoffline_step'
   [299] Prefetching for module NanoAODDQM/'nanoDQMMC'
   [300] Prefetching for module SimpleHTXSFlatTableProducer/'HTXSCategoryTable'
   [301] Prefetching for module HTXSRivetProducer/'rivetProducerHTXS'
   [302] Prefetching for module GenParticles2HepMCConverter/'genParticles2HepMCHiggsVtx'
   [303] While reading from source GenEventInfoProduct generator '' SIM
   [304] Rethrowing an exception that happened on a different read request.
   [305] Processing  Event run: 1 lumi: 19 event: 901 stream: 0
   [306] Running path 'dqmoffline_step'
   [307] Prefetching for module NanoAODDQM/'nanoDQMMC'
   [308] Prefetching for module SimpleHTXSFlatTableProducer/'HTXSCategoryTable'
   [309] Prefetching for module HTXSRivetProducer/'rivetProducerHTXS'
   [310] Prefetching for module GenParticles2HepMCConverter/'genParticles2HepMCHiggsVtx'
   [311] Prefetching for module MergedGenParticleProducer/'mergedGenParticles'
   [312] While reading from source std::vector<pat::PackedGenParticle> packedGenParticles '' RECO
   [313] Rethrowing an exception that happened on a different read request.
   [314] Processing  Event run: 1 lumi: 19 event: 901 stream: 0
   [315] Running path 'dqmoffline_step'
   [316] Prefetching for module NanoAODDQM/'nanoDQMMC'
   [317] Prefetching for module SimpleHTXSFlatTableProducer/'HTXSCategoryTable'
   [318] Prefetching for module HTXSRivetProducer/'rivetProducerHTXS'
   [319] Prefetching for module GenParticles2HepMCConverter/'genParticles2HepMCHiggsVtx'
   [320] Prefetching for module MergedGenParticleProducer/'mergedGenParticles'
   [321] While reading from source std::vector<reco::GenParticle> prunedGenParticles '' RECO
   [322] Reading branch recoGenParticles_prunedGenParticles__RECO.
   [323] Calling XrdFile::readv()
   [324] XrdAdaptor::ClientRequest::HandleResponse() failure while running connection recovery
   [325] Handling XrdAdaptor::RequestManager::requestFailure()
   [326] In XrdAdaptor::RequestManager::OpenHandler::HandleResponseWithHosts()
Exception Message:
XrdCl::File::Open(name='root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/relval/CMSSW_10_6_14/RelValTTbar_13/MINIAODSIM/PU25ns_106X_mc2017_realistic_v7-v1/10000/D4CC593C-E3A1-F544-9D06-95168FEF6F7C.root', flags=0x10, permissions=0660) => error '[ERROR] Server responded with an error: [3014] Unable to open file  /eos/cms/store/user/cmsbuild/store/relval/CMSSW_10_6_14/RelValTTbar_13/MINIAODSIM/PU25ns_106X_mc2017_realistic_v7-v1/10000/D4CC593C-E3A1-F544-9D06-95168FEF6F7C.root; Network is unreachable
' (errno=3014, code=400)
   Additional Info:
      [a] Original error: '[ERROR] Socket timeout' (errno=0, code=103, source=p06636710p75593.cern.ch:1095 (unknown site)).
      [b] Original failed source is p06636710p75593.cern.ch:1095 (unknown site)
      [c] Disabled source: p06636710p75593.cern.ch:1095
----- End Fatal Exception -------------------------------------------------

tvami · 2022-02-23T20:40:38Z

@cmsbuild , please test

cmsbuild · 2022-02-24T00:40:06Z

-1

Failed Tests: AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-975475/22627/summary.html
COMMIT: aa32bcf
CMSSW: CMSSW_12_3_X_2022-02-23-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37050/22627/install.sh to create a dev area with all the needed externals and cmssw changes.

AddOn Tests

hlt_mc_PRefcmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run3_mc_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run3 --processName=HLTRECO --filein file:RelVal_Raw_PRef_MC.root --fileout file:RelVal_Raw_PRef_MC_HLT_RECO.root : FAILED - time: date Wed Feb 23 22:03:10 2022-date Wed Feb 23 21:55:33 2022 s - exit: 35584

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-975475/1041.0_RunExpressPhy2017F+RunExpressPhy2017F+TIER0EXPPPSCAL+ALCASPLITPPSCAL+ALCAHARVDPPSCAL
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-975475/1042.0_RunExpressPhy2017F+RunExpressPhy2017F+TIER0EXPPPSCALALIG+ALCASPLITPPSALIG+ALCAHARVDPPSALIG

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 4001143
DQMHistoTests: Total failures: 8
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4001113
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 204 log files, 45 edm output root files, 49 DQM output files
TriggerResults: no differences found

tvami · 2022-02-24T02:46:59Z

https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-975475/22627/addOnTests/hlt_mc_PRef/cmsDriver.py_RelVal_-s_HLT:PRef,RAW2DIGI,L1Reco,RECO_--mc_--scenario=pp_-n_10_--conditions_auto:run3_mc_PRef_--relval_9000,50_--datatier_RAW-HLT-RECO.log

This doesnt seem related...

tvami · 2022-02-24T02:47:06Z

@cmsbuild , please test

cmsbuild · 2022-02-24T08:23:15Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-975475/22632/summary.html
COMMIT: aa32bcf
CMSSW: CMSSW_12_3_X_2022-02-23-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37050/22632/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-975475/1041.0_RunExpressPhy2017F+RunExpressPhy2017F+TIER0EXPPPSCAL+ALCASPLITPPSCAL+ALCAHARVDPPSCAL
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-975475/1042.0_RunExpressPhy2017F+RunExpressPhy2017F+TIER0EXPPPSCALALIG+ALCASPLITPPSALIG+ALCAHARVDPPSALIG

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 4001143
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4001119
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 204 log files, 45 edm output root files, 49 DQM output files
TriggerResults: no differences found

tvami · 2022-02-24T13:13:22Z

+alca

The output of 1041 and 1042 looks good
no diffs in Jenkins

cmsbuild · 2022-02-24T13:13:45Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2022-02-24T13:27:37Z

+1

Christopher and others added 3 commits February 22, 2022 15:45

Replaced InputTag with a vector of InputTags in the alignment worker

2e4fcae

Modify Timing PCL products for a new producer

4f0a356

code-format

db20e12

cmsbuild added this to the CMSSW_12_3_X milestone Feb 23, 2022

cmsbuild added alca-pending code-checks-pending orp-pending pending-signatures tests-pending labels Feb 23, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 23, 2022

tvami reviewed Feb 23, 2022

View reviewed changes

CalibPPS/AlignmentGlobal/plugins/PPSAlignmentWorker.cc Outdated Show resolved Hide resolved

tvami reviewed Feb 23, 2022

View reviewed changes

CalibPPS/TimingCalibration/plugins/PPSDiamondSampicTimingCalibrationPCLWorker.cc Show resolved Hide resolved

tvami reviewed Feb 23, 2022

View reviewed changes

CalibPPS/TimingCalibration/plugins/PPSTimingCalibrationPCLWorker.cc Outdated Show resolved Hide resolved

tvami reviewed Feb 23, 2022

View reviewed changes

CalibPPS/TimingCalibration/plugins/PPSTimingCalibrationPCLWorker.cc Show resolved Hide resolved

Added const to many member variables.

aa32bcf

cmsbuild added code-checks-pending and removed code-checks-approved labels Feb 23, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 23, 2022

cmsbuild added tests-started and removed tests-pending labels Feb 23, 2022

cmsbuild removed the tests-started label Feb 23, 2022

cmsbuild added the tests-rejected label Feb 23, 2022

cmsbuild added tests-started and removed tests-rejected labels Feb 23, 2022

cmsbuild added tests-rejected and removed tests-started labels Feb 24, 2022

cmsbuild added tests-started and removed tests-rejected labels Feb 24, 2022

cmsbuild added tests-approved and removed tests-started labels Feb 24, 2022

cmsbuild added alca-approved fully-signed and removed alca-pending pending-signatures labels Feb 24, 2022

cmsbuild added orp-approved and removed orp-pending labels Feb 24, 2022

cmsbuild merged commit 6105a4c into cms-sw:master Feb 24, 2022

MatiXOfficial deleted the pps_pcl_update branch February 24, 2022 13:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updated the PPS PCL workers to support the new AlCaRecoProducer #37050

Updated the PPS PCL workers to support the new AlCaRecoProducer #37050

MatiXOfficial commented Feb 23, 2022

cmsbuild commented Feb 23, 2022

cmsbuild commented Feb 23, 2022

tvami commented Feb 23, 2022

cmsbuild commented Feb 23, 2022

cmsbuild commented Feb 23, 2022

tvami commented Feb 23, 2022

cmsbuild commented Feb 23, 2022

tvami commented Feb 23, 2022

cmsbuild commented Feb 24, 2022

tvami commented Feb 24, 2022

tvami commented Feb 24, 2022

cmsbuild commented Feb 24, 2022

tvami commented Feb 24, 2022

cmsbuild commented Feb 24, 2022

qliphy commented Feb 24, 2022

Updated the PPS PCL workers to support the new AlCaRecoProducer #37050

Updated the PPS PCL workers to support the new AlCaRecoProducer #37050

Conversation

MatiXOfficial commented Feb 23, 2022

PR description:

PR validation:

cmsbuild commented Feb 23, 2022

cmsbuild commented Feb 23, 2022

tvami commented Feb 23, 2022

cmsbuild commented Feb 23, 2022

cmsbuild commented Feb 23, 2022

tvami commented Feb 23, 2022

cmsbuild commented Feb 23, 2022

RelVals

tvami commented Feb 23, 2022

cmsbuild commented Feb 24, 2022

AddOn Tests

Comparison Summary

tvami commented Feb 24, 2022

tvami commented Feb 24, 2022

cmsbuild commented Feb 24, 2022

Comparison Summary

tvami commented Feb 24, 2022

cmsbuild commented Feb 24, 2022

qliphy commented Feb 24, 2022