Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAQ - fixing streamer count of HLT paths with the GlobalEvFOutputModule (12_2_X) #37055

Merged
merged 2 commits into from Feb 26, 2022

Conversation

smorovic
Copy link
Contributor

PR description:
Calculating trigger names and module ID in constructor so that it is
available both for for serializeRegistry and serializing event with the
GlobalEvFOutputMOdule

Resolves #37029

This issue is critical for DQM for running in CRAFT from the Feb 28th.

PR validation:
Tested with a scripted test:
/afs/cern.ch/user/s/smorovic/public/test_outputmodule (see also #37029)
The test passes with this patch.
The test will also be integrated into the existing unit test (pending work planned for another PR).

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #37054

available both for for serializeRegistry and serializing event with the
GlobalEvFOutputMOdule
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 24, 2022

A new Pull Request was created by @smorovic (Srecko Morovic) for CMSSW_12_2_X.

It involves the following packages:

  • EventFilter/Utilities (daq)
  • IOPool/Streamer (core)

@smuzaffar, @Dr15Jones, @makortel, @emeschi, @cmsbuild, @smorovic can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @wddgit, @makortel this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@smorovic
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e9fdb2/22642/summary.html
COMMIT: 533f84a
CMSSW: CMSSW_12_2_X_2022-02-23-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37055/22642/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 3251294
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3251272
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@smorovic
Copy link
Contributor Author

+1

@makortel
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@francescobrivio
Copy link
Contributor

backport of #37054

@francescobrivio
Copy link
Contributor

urgent

  • possibly needed for CRAFT

@qliphy
Copy link
Contributor

qliphy commented Feb 26, 2022

+1

@cmsbuild cmsbuild merged commit a198c0b into cms-sw:CMSSW_12_2_X Feb 26, 2022
@smorovic smorovic deleted the 12X-streameroutput branch August 24, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants