MTD validation: update cluster histograms

[fabiocos]

PR description:

Addition of histograms for better monitoring of cluster characteristics and position.

PR validation:

On workflow 35034.0 the observed dqmMemoryStat memory increase in normal conditions (without activating flag for dedicated studies) is of about 3 kB:

71c71
< 1136.00 KiB      MTD/ETL
---
> 1135.12 KiB      MTD/ETL
123c123
< 243.73 KiB       MTD/BTL
---
> 241.82 KiB       MTD/BTL
411c411
< Total bytes: 413140.61 KiB
---
> Total bytes: 413137.82 KiB

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37056/28502

• This PR adds an extra 28KB to repository

[cmsbuild]

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

• Validation/MtdValidation (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[fabiocos]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-45478d/22648/summary.html
COMMIT: 2c51320
CMSSW: CMSSW_12_3_X_2022-02-23-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37056/22648/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 4001143
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 4001113
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 22.332 KiB( 48 files compared)
• DQMHistoSizes: changed ( 23234.0,... ): 1.913 KiB MTD/BTL
• DQMHistoSizes: changed ( 23234.0,... ): 0.879 KiB MTD/ETL
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 204 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[jfernan2]

Hi @fabiocos
I guess the binning in the plots for the unmatched cluster energy is expecting larger energies from more statistics, right?

https://tinyurl.com/y8p9er6t
Thanks

[fabiocos]

@jfernan2 in principle there should be no unmatched cluster. I've already removed plots for time and eta of these cases, the binning is matching that for the regular clusters. I may reduce the number of bins by just plotting the log10 of the energy, perhaps a better alternative to a simple counter

[jfernan2]

It is fine. I was just wondering why the energy was accumulating in the left side of the plot, I thought it was due to the reduced stats of the Jenkins test. You are adding less than 3KB of new MEs, this is definitely not a problem

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

@jfernan2 we are speaking just of 1 kB, nevertheless I believe that log10 would ok for this purpose (slightly more than a counter). In case a problem is observed, amore detailed analysis will be needed anyway

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37056/28526

• This PR adds an extra 28KB to repository

[cmsbuild]

Pull request #37056 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please check and sign again.

[fabiocos]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-45478d/22676/summary.html
COMMIT: 5ce5f7c
CMSSW: CMSSW_12_3_X_2022-02-25-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37056/22676/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 4001143
• DQMHistoTests: Total failures: 14
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 4001107
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 13.432 KiB( 48 files compared)
• DQMHistoSizes: changed ( 23234.0,... ): 1.542 KiB MTD/BTL
• DQMHistoSizes: changed ( 23234.0,... ): 0.137 KiB MTD/ETL
• Checked 204 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1