HCAL HcalTBSource: adding skipEvents parameter

[abdoulline]

PR description:

Minor amendment to HCAL proprietary HcalTBSource in a way similar to regular source "skipEvents" for analysis convenience.

PR validation:

runTheMatrix -l limited

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37058/28506

• This PR adds an extra 12KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37058/28506/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37058/28506/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[abdoulline]

Strange. I did run scram build code-format...

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37058/28507

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @abdoulline (Salavat Abdullin) for master.

It involves the following packages:

• IORawData/HcalTBInputService (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@bsunanda, @mmusich, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[tvami]

Hi @abdoulline sorry I'm not sure I understand why this needs to be in the cc code. IIRC the cmsDriver based configs have the skip event option, i.e what you do here can be done at the config level, no? I mean the skipEvents in here
https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideEDMParametersForModules#The_options_Parameter_Set

[tvami]

@cmsbuild , please test

[abdoulline]

@tvami actually it's a "private" HCAL code (initially created/intended for the test beam of detector prototypes) used mostly locally for HCAL prompt feedback data analysis. So mimicking regular PoolSource "skipEvents" parameter is quite convenient for using this kind of fragment in config. E.g. to select specified events from HCAL local run.

process.source = cms.Source("HcalTBSource",
#process.source = cms.Source("PoolSource",
firstLuminosityBlockForEachRun = cms.untracked.VLuminosityBlockID(),
fileNames = cms.untracked.vstring(options.inputFiles),
skipEvents = cms.untracked.uint32(4100)
)

NB: recently some colleagues started using it as shown above and found this didn't work, so I've just "parched" the code to make it work...

[tvami]

@abdoulline I see, thanks for the explanation. I was wondering if you were interested in adding a unit test that runs this code in the Jenkins?

[abdoulline]

@tvami this code is not running in any wf, it's a specialized input source code, which is all the time used in HCAL, so don't think it needs a unit test.

[tvami]

@cmsbuild , please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-74ccdd/22655/summary.html
COMMIT: 515390e
CMSSW: CMSSW_12_3_X_2022-02-24-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37058/22655/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 4001143
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 4001119
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 204 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[tvami]

+alca

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1