Run3-alca219 Cleanup some of the classes in Calibration/HcalCalibAlgos #37070

bsunanda · 2022-02-25T14:08:10Z

PR description:

Cleanup some of the classes in Calibration/HcalCalibAlgos

PR validation:

Use the runTheMatrix test workflows

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

cmsbuild · 2022-02-25T14:16:57Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37070/28522

This PR adds an extra 76KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37070/28522/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37070/28522/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2022-02-25T14:33:00Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37070/28524

This PR adds an extra 76KB to repository

cmsbuild · 2022-02-25T14:33:21Z

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

Calibration/HcalCalibAlgos (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

tvami · 2022-02-25T14:50:52Z

Calibration/HcalCalibAlgos/test/HcalCorrPFCalculation.cc

-  ev.getByToken(tok_ho_, hocoll);
+  const edm::Handle<HORecHitCollection>& hocoll = ev.getHandle(tok_ho_);
  const HORecHitCollection Hitho = *(hocoll.product());


Isnt there a getData method for these? is case the handle is not used for the validity check, and the getData exists, this could be further simplified

cmsbuild · 2022-02-25T18:00:37Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37070/28529

This PR adds an extra 80KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37070/28529/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37070/28529/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2022-02-25T18:26:08Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37070/28532

This PR adds an extra 80KB to repository

cmsbuild · 2022-02-25T18:26:33Z

Pull request #37070 was updated. @cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please check and sign again.

bsunanda · 2022-02-25T18:30:38Z

@cmsbuild Please test

tvami · 2022-02-25T18:36:19Z

Calibration/HcalCalibAlgos/test/HcalCorrPFCalculation.cc

-  const HORecHitCollection Hitho = *(hocoll.product());
+  const HBHERecHitCollection & Hithbhe = ev.get(tok_hbhe_);;
+  const HFRecHitCollection & Hithf = ev.get(tok_hf_);
+  //  const HORecHitCollection & Hitho = ev.get(tok_ho_);


should this be uncommented?

Currently Hitho is not used in the code. It is kept for future extension of the code. I prefer to keep this commented rather than deleting the line altogether.

cmsbuild · 2022-02-25T22:25:08Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fa174d/22679/summary.html
COMMIT: bfad700
CMSSW: CMSSW_12_3_X_2022-02-25-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37070/22679/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 4001143
DQMHistoTests: Total failures: 13
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 4001107
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 48 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 204 log files, 45 edm output root files, 49 DQM output files
TriggerResults: no differences found

tvami · 2022-02-25T22:32:20Z

+alca

cmsbuild · 2022-02-25T22:32:45Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2022-02-26T01:50:58Z

+1

Cleanup some of the classes in Calibration/HcalCalibAlgos

06a5a5f

cmsbuild added this to the CMSSW_12_3_X milestone Feb 25, 2022

cmsbuild added alca-pending code-checks-pending orp-pending pending-signatures tests-pending labels Feb 25, 2022

cmsbuild added code-checks-rejected and removed code-checks-pending labels Feb 25, 2022

Code heck

8c7e344

cmsbuild added code-checks-pending and removed code-checks-rejected labels Feb 25, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 25, 2022

tvami reviewed Feb 25, 2022

View reviewed changes

replace a few getHandle with get

34e8bba

cmsbuild added code-checks-pending and removed code-checks-approved labels Feb 25, 2022

cmsbuild added code-checks-rejected and removed code-checks-pending labels Feb 25, 2022

Code check

c6679c1

cmsbuild added code-checks-pending and removed code-checks-rejected labels Feb 25, 2022

Code check

bfad700

cmsbuild removed the code-checks-pending label Feb 25, 2022

cmsbuild added the code-checks-approved label Feb 25, 2022

cmsbuild added tests-started and removed tests-pending labels Feb 25, 2022

tvami reviewed Feb 25, 2022

View reviewed changes

cmsbuild added tests-approved and removed tests-started labels Feb 25, 2022

cmsbuild added alca-approved fully-signed and removed alca-pending pending-signatures labels Feb 25, 2022

cmsbuild added orp-approved and removed orp-pending labels Feb 26, 2022

cmsbuild merged commit 942cf0f into cms-sw:master Feb 26, 2022

This was referenced Feb 26, 2022

New dasgoclient version cms-sw/cmsdist#7650

Merged

added unit test for das-selected-lumis.py #37072

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Run3-alca219 Cleanup some of the classes in Calibration/HcalCalibAlgos #37070

Run3-alca219 Cleanup some of the classes in Calibration/HcalCalibAlgos #37070

bsunanda commented Feb 25, 2022

cmsbuild commented Feb 25, 2022

cmsbuild commented Feb 25, 2022

cmsbuild commented Feb 25, 2022

tvami Feb 25, 2022

cmsbuild commented Feb 25, 2022

cmsbuild commented Feb 25, 2022

cmsbuild commented Feb 25, 2022

bsunanda commented Feb 25, 2022

tvami Feb 25, 2022

bsunanda Feb 25, 2022

cmsbuild commented Feb 25, 2022

tvami commented Feb 25, 2022

cmsbuild commented Feb 25, 2022

qliphy commented Feb 26, 2022

Run3-alca219 Cleanup some of the classes in Calibration/HcalCalibAlgos #37070

Run3-alca219 Cleanup some of the classes in Calibration/HcalCalibAlgos #37070

Conversation

bsunanda commented Feb 25, 2022

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Feb 25, 2022

cmsbuild commented Feb 25, 2022

cmsbuild commented Feb 25, 2022

tvami Feb 25, 2022

Choose a reason for hiding this comment

cmsbuild commented Feb 25, 2022

cmsbuild commented Feb 25, 2022

cmsbuild commented Feb 25, 2022

bsunanda commented Feb 25, 2022

tvami Feb 25, 2022

Choose a reason for hiding this comment

bsunanda Feb 25, 2022

Choose a reason for hiding this comment

cmsbuild commented Feb 25, 2022

Comparison Summary

tvami commented Feb 25, 2022

cmsbuild commented Feb 25, 2022

qliphy commented Feb 26, 2022