HCAL: update(psm) of DPGAnalysis/HcalTools for Run3

[zhokin2]

• new directories are added to provide Phi-Symmetry Monitoring
  for different Global(!) runs with aim of preparation of
  hcal calibration by Iteration method and
  Method of Moments (calibration group);

talk of Olga Kodolova, which can clarify Method of Moments:
https://indico.cern.ch/event/1099868/contributions/4627590/attachments/2353777/4016084/phi_symmetry_mm_26112021.pdf

my talk on HCAL DPG Workshop (14-15 Oct) 2021. See p.8-10 to clarify PSM implementation:
https://indico.cern.ch/event/1082970/contributions/4565247/attachments/2328302/3966806/HCAL-DPG-Workshop2021.pdf

• macros corrected for use TFileservice

• updates and bugs fixed in some scripts
  regarding CMT and RMT

last talk on DPG meeting:
https://indico.cern.ch/event/1099868/contributions/4629402/attachments/2353858/4016211/zzzhcal72.pdf

PR validation:

scram build code-checks
scram build code-format
scram b

the CMT, RMT and PSM tests were done locally and with use of cms-sites :
https://cms-conddb.cern.ch/eosweb/hcal/HcalRemoteMonitoring/AMT
https://cms-conddb.cern.ch/eosweb/hcal/HcalRemoteMonitoring/RMT
https://cms-conddb.cern.ch/eosweb/hcal/HcalRemoteMonitoring/CMT
https://cms-conddb.cern.ch/eosweb/hcal/HcalRemoteMonitoring/GlobalRMT
https://cms-conddb.cern.ch/eosweb/hcal/HcalRemoteMonitoring/GlobalPSM
https://cms-conddb.cern.ch/eosweb/hcal/HcalRemoteMonitoring/ALCARECOPSM
https://cms-conddb.cern.ch/eosweb/hcal/HcalRemoteMonitoring/IMPSM

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37082/28563

• This PR adds an extra 980KB to repository

[cmsbuild]

A new Pull Request was created by @zhokin2 (zhokin) for master.

It involves the following packages:

• DPGAnalysis/HcalTools (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[abdoulline]

@zhokin2 Sasha, could you, please, edit your PR name to make it less cryptic and more meaningful (self-explanatory) -
something like
"HCAL: update of DPGAnalysis/HcalTools"

[jfernan2]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1d553a/22707/summary.html
COMMIT: 09ec01d
CMSSW: CMSSW_12_3_X_2022-02-27-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37082/22707/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 4001207
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 4001177
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 204 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

@zhokin2 @abdoulline all this code looks like private HCAL code, not meant for any centrally run workflow: can you please confirm?

Also the CMTRawAnalyzer plugin seems to be meant only to some local HCAL monitoring. see
https://cmssdt.cern.ch/lxr/search?%21v=CMSSW_12_3_X_2022-03-03-2300&_filestring=&_string=CMTRawAnalyzer&_casesensitive=1

If so, we can fully rely on your evaluation and review for assessing the usefulness of this update in the centrally managed software, and merge it based on it (without inspecting in detail the 90k+ modified lines of code)

Please let us know.

[abdoulline]

@perrotta ( and @zhokin2)
yes, this is a set of proprietary HCAL tools, not meant to run in any central wf.

[perrotta]

+1

• (Thank you Salavat for confirmation)