Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new L1T menu for Run-3 MC GTs #37089

Merged
merged 1 commit into from Mar 1, 2022
Merged

Conversation

tvami
Copy link
Contributor

@tvami tvami commented Feb 28, 2022

PR description:

Add new L1T menu for Run-3 MC GTs as requested in https://cms-talk.web.cern.ch/t/mc-run3-update-l1menu-in-gts/7522

The new GTs, and their diffs wrt to the autoCond are

Diffs are in the requested L1Menu_Collisions2022_v0_1_5_xml tag only.

PR validation:

workflows = 12034.0,11634.0,7.23,159.0,12434.0,12834.0

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

@tvami
Copy link
Contributor Author

tvami commented Feb 28, 2022

test parameters:

  • workflows = 12034.0,11634.0,7.23,159.0,12434.0,12834.0

@tvami
Copy link
Contributor Author

tvami commented Feb 28, 2022

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37089/28577

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @tvami (Tamas Vami) for master.

It involves the following packages:

  • Configuration/AlCa (alca)

@malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eecdfd/22719/summary.html
COMMIT: 47fb6e0
CMSSW: CMSSW_12_3_X_2022-02-28-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37089/22719/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eecdfd/22719/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eecdfd/22719/git-merge-result

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-eecdfd/12034.0_TTbar_14TeV+2021Design+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-eecdfd/7.23_Cosmics_UP21+Cosmics_UP21+DIGICOS_UP21+RECOCOS_UP21+ALCACOS_UP21+HARVESTCOS_UP21

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 4000857
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4000833
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -1601.64 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): -52.142 KiB Castor/CastorDigiMonitor
  • DQMHistoSizes: changed ( 11634.0,... ): -47.449 KiB Castor/CastorRecHitMonitor
  • DQMHistoSizes: changed ( 11634.0,... ): -28.180 KiB Castor/average E(digi) in BXtrig
  • DQMHistoSizes: changed ( 11634.0,... ): -28.176 KiB Castor/average E(digi) in BX
  • DQMHistoSizes: changed ( 11634.0,... ): -4.043 KiB Castor/E(digi)vsTriggerIndex
  • DQMHistoSizes: changed ( 11634.0,... ): -0.088 KiB Castor/CastorEventProducts
  • DQMHistoSizes: changed ( 11634.0,... ): -0.087 KiB Castor/CASTORUnpackReport
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor Author

tvami commented Mar 1, 2022

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eecdfd/22729/summary.html
COMMIT: 47fb6e0
CMSSW: CMSSW_12_3_X_2022-02-28-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37089/22729/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-eecdfd/12034.0_TTbar_14TeV+2021Design+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-eecdfd/7.23_Cosmics_UP21+Cosmics_UP21+DIGICOS_UP21+RECOCOS_UP21+ALCACOS_UP21+HARVESTCOS_UP21

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 4000857
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4000833
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@francescobrivio
Copy link
Contributor

+alca

  • new results are clean (except the usual few MTD differences)

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Mar 1, 2022

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants