Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the vertex matching algorithm for taus #3709

Merged
merged 4 commits into from May 7, 2014

Conversation

jpavel
Copy link
Contributor

@jpavel jpavel commented May 6, 2014

Redesign of vertex-to-jet matching algorithm used by tauReco. The only functional change is the possibility to select which way the jet leading PFcandidate will be selected. Also, the default matching was changed from using track weights to using deltaZ.

The performance is slightly affected in a positive way - increased efficiency and decreased fake rate

The change in performance is documented here: https://indico.cern.ch/event/316898/material/1/0.pdf

This pull request contains the fix for memory leak from #3666 and does not interfere with ak5->ak4 transition

@monicava, @veelken - you want to watch this

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2014

A new Pull Request was created by @jpavel (Pavel Jez) for CMSSW_7_1_X.

Changing the vertex matching algorithm for taus

It involves the following packages:

RecoTauTag/RecoTau

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2014

@anton-a
Copy link

anton-a commented May 7, 2014

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request May 7, 2014
Reco -- Changing the vertex matching algorithm for taus
@ktf ktf merged commit 51638b8 into cms-sw:CMSSW_7_1_X May 7, 2014
@jpavel jpavel deleted the 71x_taus_dZVxmatch branch May 7, 2014 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants