Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT menu development for 12_3_X #37114

Merged
merged 1 commit into from Mar 2, 2022

Conversation

missirol
Copy link
Contributor

@missirol missirol commented Mar 2, 2022

PR description:

Development of HLT menus for CMSSW_12_3_X.

Includes the integration of the following JIRA tickets.

  • CMSHLT-2231: [TSG] cleanup of Scouting-related EndPaths.
  • CMSHLT-2232: [BPH] update of BPH triggers for Run-3 tracking and update of DoubleMuonLowMass PrimaryDataset.
  • CMSHLT-2237: [HIG] multijet+btags triggers using ParticleNet.
  • CMSHLT-2239: [TSG] removal of unused PSets in HLT menus.

This update also includes a change of the default GT string to None (instead of an arbitrary old GT), in order to force users to update it properly.

PR validation:

TSG tests.

If this PR is a backport, please specify the original PR and why you need to backport that PR:

N/A

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37114/28615

  • This PR adds an extra 764KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2022

A new Pull Request was created by @missirol (Marino Missiroli) for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

missirol commented Mar 2, 2022

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2d4bda/22757/summary.html
COMMIT: f602b61
CMSSW: CMSSW_12_3_X_2022-03-01-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37114/22757/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3997263
  • DQMHistoTests: Total failures: 122
  • DQMHistoTests: Total nulls: 6
  • DQMHistoTests: Total successes: 3997113
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -6538.53 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): -1091.170 KiB HLT/BPH
  • DQMHistoSizes: changed ( 11634.0,... ): 1.415 KiB HLT/Filters
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 7 / 48 workflows

@missirol
Copy link
Contributor Author

missirol commented Mar 2, 2022

+hlt

  • differences in the outputs of Run-3 wfs are consistent with the updates of the HLT GRun menu
  • @perrotta @qliphy , unless you have comments on this PR, it would be useful to have it already in the 23:00 IB (to spot any possible issues early, as the 12_3_0_pre6 deadline approaches)

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Mar 2, 2022

+1

@cmsbuild cmsbuild merged commit 052fbab into cms-sw:master Mar 2, 2022
@missirol missirol deleted the HLTdevelopment123X branch March 2, 2022 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants