DQM HLT Muon cleaning

[andrea21z]

PR description:

This PR is created to remove unnecessary histograms for DQM HLT Muon validation. Summary:

• Remove folders for different ID working points.
• Keep only the most representative HLT folders.
• Remove histograms that are not used in the validation. Keep only the monitor elements: efficiencyEta, efficiencyPhi, efficiencyTurnOn and efficiencyCharge.

PR validation:

• I check the output of the new branch running runTheMatrix and everything looks as expected.
• I execute the basic test suggested in the CMSSW PR instructions.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37117/28631

• This PR adds an extra 28KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37117/28631/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37117/28631/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37117/28632

• This PR adds an extra 28KB to repository

[cmsbuild]

A new Pull Request was created by @andrea21z for master.

It involves the following packages:

• DQMOffline/Trigger (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@sscruz, @missirol, @mtosi, @Fedespring, @calderona, @HuguesBrun, @jhgoh, @trocino, @cericeci, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

-1

Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-686dff/22774/summary.html
COMMIT: 7be0345
CMSSW: CMSSW_12_3_X_2022-03-02-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37117/22774/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

• 140.53140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/step2_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI.log

RelVals-INPUT

• 140.53140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/step2_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI.log
• 140.52140.52_RunHI2010+RunHI2010+RECOHID10+RECOHIR10D11+HARVESTDHI/step2_RunHI2010+RunHI2010+RECOHID10+RECOHIR10D11+HARVESTDHI.log
• 1004.01004.0_RunHI2011+RunHI2011+TIER0EXPHI+ALCAEXPHI+ALCAHARVD1HI+ALCAHARVD2HI+ALCAHARVD3HI+ALCAHARVD5HI/step2_RunHI2011+RunHI2011+TIER0EXPHI+ALCAEXPHI+ALCAHARVD1HI+ALCAHARVD2HI+ALCAHARVD3HI+ALCAHARVD5HI.log

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37117/28662

• This PR adds an extra 24KB to repository

[cmsbuild]

Pull request #37117 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please check and sign again.

[jfernan2]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-686dff/22906/summary.html
COMMIT: e55f467
CMSSW: CMSSW_12_3_X_2022-03-07-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37117/22906/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3758867
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 270
• DQMHistoTests: Total successes: 3758573
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -49274.139 KiB( 48 files compared)
• DQMHistoSizes: changed ( 1000.0 ): -358.350 KiB HLT/Muon
• DQMHistoSizes: changed ( 11634.0,... ): -8088.403 KiB HLT/Muon
• DQMHistoSizes: changed ( 4.22 ): -385.371 KiB HLT/Muon
• Checked 204 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1
Histograms removed after cleaning campaign: ~42k

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

• Cleaning of DQM HLT histos
• Some cleaning to the code itself is also advisabe, for a forthcoming PR