Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update monopole skim for Run-3. #37151

Merged
merged 3 commits into from Mar 16, 2022
Merged

Conversation

srimanob
Copy link
Contributor

@srimanob srimanob commented Mar 6, 2022

PR description:

This PR is to update the monopole skim for Run-3. The trigger should be updated, but from the current list at
https://docs.google.com/spreadsheets/d/1UIR0YISWX1r2wfk-r7bPlVmHwguoVgjvGEw3nTgZd-c/edit?usp=sharing
HLT_Photon200_v still be an unprescaled trigger for Run-3

Size comparison (see issue #37150 for compression):

  • Old without compression: 2.22 MB/event
  • New without compression: 1.86 MB/event
  • New with compression LZMA-level4: 1.66 MB/event (75% of Run-2)
  • New with compression ZSTD-level4: 1.74 MB/event

We should get the conclusion from the above issue first before merging the PR, i.e. if each team should take care for compression in their code, or it will be organized centrally somehow.

PR validation:

cmsDriver.py step3 --conditions auto:run2_data -s RAW2DIGI,L1Reco,RECO,SKIM:EXOMONOPOLE+BPHSkim,PAT --datatier AOD,MINIAOD --eventcontent AOD,MINIAOD --data --process reRECO --scenario pp --era Run2_2018 --customise Configuration/DataProcessing/RecoTLR.customisePostEra_Run2_2018 --python MONOPOLE_cfg.py -n 500 --no_exec --filein file:root://eoscms.cern.ch//eos/cms/store/data/Run2018D/EGamma/RAW/v1/000/320/822/00000/1441432A-8997-E811-8BD0-FA163EA21B5C.root --fileout file:step3.root --nThreads 8
(adapt from wf 136.886)

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport and no need of backport.

@srimanob
Copy link
Contributor Author

srimanob commented Mar 6, 2022

test parameters:

  • workflow = 136.886

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37151/28699

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2022

A new Pull Request was created by @srimanob (Phat Srimanobhas) for master.

It involves the following packages:

  • Configuration/Skimming (pdmv)

@cmsbuild, @bbilin, @wajidalikhan, @kskovpen, @jordan-martins can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@srimanob
Copy link
Contributor Author

srimanob commented Mar 6, 2022

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37151/28700

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2022

Pull request #37151 was updated. @cmsbuild, @bbilin, @wajidalikhan, @kskovpen, @jordan-martins can you please check and sign again.

@srimanob
Copy link
Contributor Author

srimanob commented Mar 6, 2022

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a409ee/22879/summary.html
COMMIT: fbe674d
CMSSW: CMSSW_12_3_X_2022-03-05-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37151/22879/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

The workflows 1001.0, 1000.0, 136.88811, 136.874, 136.8311, 136.793, 136.7611, 136.731, 4.22 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3987741
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3987705
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 1 / 48 workflows

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37151/28702

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2022

Pull request #37151 was updated. @cmsbuild, @bbilin, @wajidalikhan, @kskovpen, @jordan-martins can you please check and sign again.

@srimanob
Copy link
Contributor Author

srimanob commented Mar 6, 2022

hold

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2022

Pull request has been put on hold by @srimanob
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild cmsbuild added the hold label Mar 6, 2022
@srimanob
Copy link
Contributor Author

srimanob commented Mar 6, 2022

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a409ee/22883/summary.html
COMMIT: bc6e73a
CMSSW: CMSSW_12_3_X_2022-03-05-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37151/22883/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 5 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3987741
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3987711
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 1 / 48 workflows

@kskovpen
Copy link
Contributor

+pdmv

@srimanob
Copy link
Contributor Author

unhold

@srimanob
Copy link
Contributor Author

From #37150 (comment), the PoolOutputModule is compressed by default. No need to worry on that.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit f0f2a87 into cms-sw:master Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants