Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for strips O2O reported in #37228 #37230

Merged
merged 1 commit into from Mar 14, 2022
Merged

Conversation

tvami
Copy link
Contributor

@tvami tvami commented Mar 13, 2022

PR description:

Fix for #37228

PR validation:

Using CondTools/SiStrip/scripts/o2oRun_SiStripDAQ.py 1 /cvmfs/cms.cern.ch/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_0_1/src/CondTools/SiStrip/python/SiStripDCS_popcon.py --debug --db sqlite:test.db I can reproduce the issue in #37228

After this PR the error is gone.
(and I get the msg that Exception: Database 'sqlite:test.db' is not known. which is fine since I anyway didnt want to upload to the DB)

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

Resolves #37228

@tvami
Copy link
Contributor Author

tvami commented Mar 13, 2022

type bugfix

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37230/28828

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @tvami (Tamas Vami) for master.

It involves the following packages:

  • CondTools/SiStrip (db)

@cmsbuild, @ggovi, @tvami, @malbouis, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich, @VinInn this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor Author

tvami commented Mar 13, 2022

@cmsbuild , please test

@tvami tvami changed the title Bugfix for Strips O2O Bugfix for strips O2O reported in #37228 Mar 13, 2022
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37230/28829

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

Pull request #37230 was updated. @ggovi, @malbouis, @tvami, @francescobrivio can you please check and sign again.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b4e3eb/23080/summary.html
COMMIT: fe3fc58
CMSSW: CMSSW_12_4_X_2022-03-13-0000/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37230/23080/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3695161
  • DQMHistoTests: Total failures: 14
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3695125
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor

mmusich commented Mar 14, 2022

urgent

  • blocker for Strip operations at P5

@ggovi
Copy link
Contributor

ggovi commented Mar 14, 2022

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Mar 14, 2022

+1

@cmsbuild cmsbuild merged commit 48ea971 into cms-sw:master Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

o2oRun_SiStripDAQ.py not fully migrated to py3
5 participants