Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_2_X] Merged central modules at L3&L4 in SiPixelLorentzAngle PCL workflow #37239

Merged
merged 2 commits into from Mar 14, 2022

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Mar 14, 2022

PR description:

This PR builds on top of #36866 to improve low statistics at central modules of L3 and L4 of Phase-I detector.

The details are:

  • Merge info from modules 3 and 4 at L3 and L4
  • Merge info from modules 5 and 6 at L3 and L4

PR validation:

Commands:

cmsDriver.py testReAlCa -s ALCA:PromptCalibProdSiPixelLorentzAngle --conditions 121X_dataRun3_Express_TIER0_REPLAY_Run2_v1 --scenario pp --data --era Run2_2018 --datatier ALCARECO --eventcontent ALCARECO --processName=ReAlCa -n 100 --dasquery='file dataset=/StreamExpress/Tier0_REPLAY_2021-SiPixelCalSingleMuon-Express-v1/ALCARECO' --customise_commands='process.ALCARECOCalSignleMuonFilterForSiPixelLorentzAngle.TriggerResultsTag = cms.InputTag ( "TriggerResults","","HLT" ) ; process.ALCARECOCalSignleMuonFilterForSiPixelLorentzAngle.HLTPaths = ["*"]' --nThreads=4
cmsDriver.py stepHarvest -s ALCAHARVEST:SiPixelLA --conditions 121X_dataRun3_Express_TIER0_REPLAY_Run2_v1 --scenario pp --data --era Run2_2018 --filein file:PromptCalibProdSiPixelLorentzAngle.root -n -1

Test results were uploaded in a private GUI: https://tinyurl.com/ycqk8odf with ssh -NL 8060:localhost:8060 <USER>@lxplus763.cern.ch

if this PR is a backport please specify the original PR and why you need to backport that PR:

backport of #37121

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 14, 2022

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_12_2_X.

It involves the following packages:

  • CalibTracker/SiPixelLorentzAngle (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@tocheng, @OzAmram, @ferencek, @mmusich, @dkotlins, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor

tvami commented Mar 14, 2022

backport of #37121

@tvami
Copy link
Contributor

tvami commented Mar 14, 2022

@cmsbuild , please test

@tvami
Copy link
Contributor

tvami commented Mar 14, 2022

+alca

  • backport, the master version works in the IBs

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_2_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

Note added for the merging of this PR: the backported PR was already merged in 12_3_0_pre6, and therefore no backport to 12_3_X is needed.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f65409/23091/summary.html
COMMIT: 61a6ba2
CMSSW: CMSSW_12_2_X_2022-03-14-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37239/23091/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 3251294
  • DQMHistoTests: Total failures: 21
  • DQMHistoTests: Total nulls: 5
  • DQMHistoTests: Total successes: 3251246
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

+1

  • Master version succesfully merged since CMSSW_12_3_0_pre6

@cmsbuild cmsbuild merged commit 8e6682e into cms-sw:CMSSW_12_2_X Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants