Ed modules migration v1

[archiron]

PR description:

add some modifications in order to avoid deprecation warnings about EDAnalyzer modules.
Modifications are made on the following files :
DQMOffline/EGamma/interface/ElectronDqmAnalyzerBase.h
DQMOffline/EGamma/plugins/ElectronAnalyzer.cc
DQMOffline/EGamma/plugins/ElectronGeneralAnalyzer.cc
DQMOffline/EGamma/plugins/ElectronTagProbeAnalyzer.cc

Some other small (they do not concern the ED Modules) modifications are made on :
Validation/RecoEgamma/test/ElectronMcFakePostValidation_cfg.py
Validation/RecoEgamma/test/ElectronMcSignalPostValidationMiniAOD_cfg.py
Validation/RecoEgamma/test/ElectronMcSignalPostValidationPt1000_cfg.py
Validation/RecoEgamma/test/ElectronMcSignalPostValidation_cfg.py

PR validation:

compilation is OK, basics tests (scram b runtests or local tests) are OK too.
runTheMatrix.py -l limited -i all --ibeos tests are fine (48 47 46 35 17 4 1 1 1 1 tests passed, 0 0 0 0 0 0 0 0 0 0 failed).
here is the run-log : runall-report-step123-.log

@beaudett

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37248/28849

• This PR adds an extra 28KB to repository

[cmsbuild]

A new Pull Request was created by @archiron (Chiron) for master.

It involves the following packages:

• DQMOffline/EGamma (dqm)
• Validation/RecoEgamma (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@rovere, @lecriste, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bcbcf8/23129/summary.html
COMMIT: 8d3e7e4
CMSSW: CMSSW_12_4_X_2022-03-15-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37248/23129/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3695377
• DQMHistoTests: Total failures: 13
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3695341
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 48 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 204 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1