New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
edmPickEvent: print the actual das output instead of json parsing error #37263
Conversation
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37263/28886
|
A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master. It involves the following packages:
@santocch can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37263/28893
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-08fb68/23191/summary.html Comparison SummarySummary:
|
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-08fb68/23194/summary.html Comparison SummarySummary:
|
comparison differences are not related to this change. |
+1
|
merge |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
#37255 should have fixed the edmPickEvent unit test but looks like dasgoclient still fails during IB tests. This PR prints the actual dasgoclient output in case of json parse errors.
Note this change does not fix the unit test itself but just to have more verbose output of edmPickEvent (in case of failures)