Update CLCT thresholds for hadronic showers in CSC

[kakwok]

PR description:

This PR updates CLCT thresholds for hadronic showers in the emulator. This change is to reflect the latest FW to be deployed in the old TMBs (ring 2 and 3), where the HMT bits of the CLCTs will be a simple pass-through. CLCT thresholds for the corresponding chambers should be zeroed in the emulator.

This proposal has been presented at the CSC Trigger meeting[1] and L1 Muon DPG meeting by @Nik-Menendez

[1] CSC Trigger meeting
[2] L1 Muon DPG

PR validation:

Validated the L1+HLT workflow with the hadronic shower trigger paths on signal MC samples in a private setup.

• CMSSW_12_3_0_pre5
• L1 Menu: L1Menu_Collisions2022_v0_1_2.xml
• HLT config: kakwok/CSCCluster_12_3_X_signalsPath/V3

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37266/28896

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @kakwok for master.

It involves the following packages:

• L1Trigger/CSCTriggerPrimitives (l1)

@epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please review it and eventually sign? Thanks.
@giovanni-mocellin, @eyigitba, @Martin-Grunewald, @missirol, @ptcox, @valuev this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[epalencia]

Please test

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dd470e/23200/summary.html
COMMIT: 8d4b00f
CMSSW: CMSSW_12_4_X_2022-03-17-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37266/23200/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

• 136.8311136.8311_RunJetHT2017F_reminiaod+RunJetHT2017F_reminiaod+REMINIAOD_data2017+HARVEST2017_REMINIAOD_data2017/step2_RunJetHT2017F_reminiaod+RunJetHT2017F_reminiaod+REMINIAOD_data2017+HARVEST2017_REMINIAOD_data2017.log
• 136.83136.83_RunDoubleMuon2017F+RunDoubleMuon2017F+HLTDR2_2017+RECODR2_2017reHLT_Prompt+HARVEST2017/step2_RunDoubleMuon2017F+RunDoubleMuon2017F+HLTDR2_2017+RECODR2_2017reHLT_Prompt+HARVEST2017.log
• 136.829136.829_RunDoubleEG2017F+RunDoubleEG2017F+HLTDR2_2017+RECODR2_2017reHLT_skimDoubleEG_Prompt+HARVEST2017_skimDoubleEG/step2_RunDoubleEG2017F+RunDoubleEG2017F+HLTDR2_2017+RECODR2_2017reHLT_skimDoubleEG_Prompt+HARVEST2017_skimDoubleEG.log

Expand to see more relval errors ...

• 136.828
• 136.831

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3695728
• DQMHistoTests: Total failures: 56
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3695649
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 48 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 204 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[kakwok]

@epalencia I didn't expect simply changing the thresholds would cause the failed tests, I also couldn't get any useful indication of the problem when the logs were available.
Could you trigger the test again to see if it still fails?

[perrotta]

please test
(Errors were quite likely unrelated: the previous tests have anyhow become too old by now)

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dd470e/23751/summary.html
COMMIT: 8d4b00f
CMSSW: CMSSW_12_4_X_2022-04-07-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37266/23751/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3593039
• DQMHistoTests: Total failures: 42
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3592975
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 200 log files, 45 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[cecilecaillol]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

• Changes in the emulator in view of the new Endcap Shower Trigger were discussed within the CSC Trigger group and with L1T