Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT release validation for new EXO-LLP Run 3 paths #37298

Merged
merged 4 commits into from Mar 31, 2022

Conversation

jalimena
Copy link
Contributor

@jalimena jalimena commented Mar 22, 2022

PR description:

This PR updates the exotica HLT release validation (in HLTriggerOffline/Exotica) to include the validation of the new long-lived particle (LLP) paths that went into v1 of the Run 3 HLT menu [1]. Complying with the request from STEAM to limit the number of histograms produced, the general philosophy going into these changes was to monitor only the signal paths, and not the backup or control paths. So, these paths have been added to the monitoring:

HLT_HT430_DelayedJet40_SingleDelay1nsTrackless_v
HLT_HT430_DelayedJet40_SingleDelay2nsInclusive_v
HLT_DoubleL2Mu23NoVtx_2Cha_CosmicSeed_v
HLT_DoubleL2Mu23NoVtx_2Cha_v
HLT_DoubleL2Mu10NoVtx_2Cha_PromptL3Mu0Veto_v
HLT_DoubleL3Mu10NoVtx_Displaced_v
HLT_HT430_DisplacedDijet30_Inclusive1PtrkShortSig5_v
HLT_Mu6HT240_DisplacedDijet30_Inclusive1PtrkShortSig5_DisplacedLoose_v
HLT_Mu20NoFiltersNoVtxDisplaced_Photon20_CaloCustomId_v
HLT_PFMET105_IsoTrk50_v
HLT_PFMET110_PFJet100_v
HLT_L1MET_DTClusterNoMB1S50_v

And these have been removed:

HLT_DoubleMu33NoFiltersNoVtxDisplaced_v
HLT_DoubleMu48NoFiltersNoVtx_v
HLT_Mu48NoFiltersNoVtx_Photon48_CaloIdL_v
HLT_Mu43NoFiltersNoVtxDisplaced_Photon43_CaloIdL_v
HLT_UncorrectedJetE30_NoBPTX_v
HLT_UncorrectedJetE30_NoBPTX3BX_v
HLT_UncorrectedJetE70_NoBPTX3BX_v
HLT_L2Mu10_NoVertex_NoBPTX_v
HLT_L2Mu10_NoVertex_NoBPTX3BX_v
HLT_L2Mu45_NoVertex_3Sta_NoBPTX3BX_v
HLT_HT400_DisplacedDijet40_DisplacedTrack_v
HLT_HT430_DisplacedDijet60_DisplacedTrack_v
HLT_HT550_DisplacedDijet60_Inclusive_v

PR validation:

Using a TTbar relval [2], I have checked that the correct histograms are produced when running

cmsRun HLTriggerOffline/Exotica/test/hltExoticaValidator_cfg.py
cmsRun HLTriggerOffline/Exotica/test/hltExoticaPostProcessor_cfg.py

I have also successfully tested this PR with

runTheMatrix.py -l limited -i all --ibeos

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport

[1] https://its.cern.ch/jira/browse/CMSHLT-2211
[2] /RelValTTbar_14TeV/CMSSW_12_3_0_pre6-123X_mcRun4_realistic_v8_2026D88noPU-v1/GEN-SIM-RECO

@cmsbuild
Copy link
Contributor

@jalimena, CMSSW_12_4_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37298/28939

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jalimena (Juliette Alimena) for master.

It involves the following packages:

  • HLTriggerOffline/Exotica (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@missirol, @mtosi this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@jalimena jalimena marked this pull request as ready for review March 25, 2022 12:41
@jalimena
Copy link
Contributor Author

hi, can we please run the tests, at least? thanks!

@perrotta
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a778f7/23494/summary.html
COMMIT: 9e5b48b
CMSSW: CMSSW_12_4_X_2022-03-29-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37298/23494/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3584444
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 6
  • DQMHistoTests: Total successes: 3584414
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 158.45399999999998 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 26.409 KiB HLT/Exotica
  • Checked 200 log files, 45 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@jfernan2
Copy link
Contributor

@jalimena I wonder if there is some duplication in the monitoring implemented in this PR w.r.t. the one in #37298
Could you please clarify?
Thanks

@jalimena
Copy link
Contributor Author

Hi @jfernan2 . This PR is #37298, the other one is #37342 . I kept them separate on purpose, in case there were any issues. There should be no duplication.
This PR handles the release validation, and all files I touched are in HLTriggerOffline/Exotica. The other PR handles the offline DQM, and all files that I touched in that PR are in DQMOffline/Trigger.

@jfernan2
Copy link
Contributor

Yes @jalimena I understand that, I mistyped the other PR, sorry. My question is if there is duplication in the monitoring, since those paths are being monitoried in both DQM and Validation, which are usually run simultaneously
Thanks

@jalimena
Copy link
Contributor Author

Hi @jfernan2 ah ok now I get it. No, the plots produced in the two packages are different.

@jfernan2
Copy link
Contributor

I see, thank you very much

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 44278bd into cms-sw:master Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants