Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[123X] Change ALCALUMIPIXELSEXPRESS to ALCALumiPixelsCountsExpress in autoAlCa.py #37328

Merged
merged 1 commit into from Mar 24, 2022

Conversation

tvami
Copy link
Contributor

@tvami tvami commented Mar 24, 2022

PR description:

See #37306

PR validation:

N/A

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #37306

@tvami
Copy link
Contributor Author

tvami commented Mar 24, 2022

backport of #37306

@tvami
Copy link
Contributor Author

tvami commented Mar 24, 2022

type bug-fix

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 24, 2022

A new Pull Request was created by @tvami (Tamas Vami) for CMSSW_12_3_X.

It involves the following packages:

  • Configuration/AlCa (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor Author

tvami commented Mar 24, 2022

test parameters:

  • workflows = 1020

@tvami
Copy link
Contributor Author

tvami commented Mar 24, 2022

@cmsbuild , please test

@tvami tvami changed the title Change ALCALUMIPIXELSEXPRESS to ALCALumiPixelsCountsExpress in autoAlCa.py [123X] Change ALCALUMIPIXELSEXPRESS to ALCALumiPixelsCountsExpress in autoAlCa.py Mar 24, 2022
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4f620e/23339/summary.html
COMMIT: 30be434
CMSSW: CMSSW_12_3_X_2022-03-23-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37328/23339/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /pool/condor/dir_49940/jenkins/workspace/compare-root-files-short-matrix/data/PR-4f620e/1020.0_AlCaLumiPixels2021+AlCaLumiPixels2021+TIER0EXPLP+ALCAEXPLP+ALCAHARVLP+TIER0PROMPTLP

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3695161
  • DQMHistoTests: Total failures: 16
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3695122
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 209 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@francescobrivio
Copy link
Contributor

+1

  • clean test results

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a0fda0d into cms-sw:CMSSW_12_3_X Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants