further miscellaneous clean-up / improvements to SiStrip payload inspector

[mmusich]

PR description:

This is a quick follow-up to #37265, for a commit that didn't make it in time in that PR.
Just a further clean-up to conform to cmssw coding rules and adding improving few plot legends for SiStripNoises and SiStripPedestals comparisons.

PR validation:

Private. Example of plots produced with the extension introduced here with the following commands:

getPayloadData.py --plugin pluginSiStripNoises_PayloadInspector \
   --plot plot_SiStripNoiseValueComparisonSingleTag \
   --tag SiStripNoise_CRAFT_21X_v4_offline \
   --input_params '{}'  \
   --time_type Run \
   --iovs '{"start_iov": "50725", "end_iov": "51415"}'  \
   --db Prod --test;
 
 getPayloadData.py --plugin pluginSiStripPedestals_PayloadInspector \
    --plot plot_SiStripPedestalValueComparisonPerStripSingleTag \
    --tag SiStripPedestals_v2_prompt \
    --input_params '{}' \
    --time_type Run \
    --iovs '{"start_iov": "348767", "end_iov": "348878"}' \
    --db Prod --test ;

SiStrip Noise	SiStrip Peds

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37333/28983

• This PR adds an extra 44KB to repository

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

• CondCore/SiStripPlugins (db)

@cmsbuild, @ggovi, @tvami, @malbouis, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich, @VinInn this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[francescobrivio]

@cmsbuild please test

[mmusich]

hold

• will further update with more graphical improvements

[cmsbuild]

Pull request has been put on hold by @mmusich
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c21da6/23355/summary.html
COMMIT: c39aaa8
CMSSW: CMSSW_12_4_X_2022-03-24-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37333/23355/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 3331 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3695650
• DQMHistoTests: Total failures: 49949
• DQMHistoTests: Total nulls: 65
• DQMHistoTests: Total successes: 3645614
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 204 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[mmusich]

unhold

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37333/28988

• This PR adds an extra 44KB to repository

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c21da6/23377/summary.html
COMMIT: 7e8a8ff
CMSSW: CMSSW_12_4_X_2022-03-24-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37333/23377/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 3639 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3695650
• DQMHistoTests: Total failures: 52558
• DQMHistoTests: Total nulls: 53
• DQMHistoTests: Total successes: 3643017
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 204 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37333/28992

• This PR adds an extra 48KB to repository

[cmsbuild]

Pull request #37333 was updated. @cmsbuild, @ggovi, @tvami, @malbouis, @francescobrivio can you please check and sign again.

[francescobrivio]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c21da6/23411/summary.html
COMMIT: ba1e8bd
CMSSW: CMSSW_12_4_X_2022-03-25-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37333/23411/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 3576 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3695650
• DQMHistoTests: Total failures: 51173
• DQMHistoTests: Total nulls: 63
• DQMHistoTests: Total successes: 3644392
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 204 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[francescobrivio]

+1

• mainly cosmetic improvements as detailed in the PR description
• differences in 39434.911 are known and already reported in Comparison failed for tests of wf 39434.911 #37315

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1