Migrate to EventSetup with ESGetToken in GEMCSCSegmentProducer (backport of #36628, 12_2_X)

[seungjin-yang]

PR description:

Backport of #36628. This PR is a technical PR to migrate to using EventSetup with ESGetToken in GEMCSCSegmentProducer.

PR validation:

GEMCSCSegmentProducer is not included in RECO. So, we can't verify this PR with any wf. So, I added GEMCSCSegmentProducer to step3 of 11850.0 for testing and confirmed it works well.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #36628. I'm planning a backport of #37178. Then, this fix should precede the backport of #37178 because #37178 uses GEMCSCSegment.

[cmsbuild]

A new Pull Request was created by @seungjin-yang (Seungjin Yang) for CMSSW_12_2_X.

It involves the following packages:

• RecoLocalMuon/GEMCSCSegment (upgrade, reconstruction)

@clacaputo, @cmsbuild, @AdrianoDee, @srimanob, @slava77, @jpata can you please review it and eventually sign? Thanks.
@bellan, @watson-ij, @jhgoh this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from Migrate to EventSetup with ESGetToken in GEMCSCSegmentProducer #36628

[perrotta]

@seungjin-yang while this PR is quite technical, and therefore probably not harming if merged in a closed production release, I don't understand why do you need it in order to backport #37178.
What would prevent backporting #37178 without this one?

[seungjin-yang]

Hi @perrotta, #37178 uses GEMCSCSegment. However, GEMCSCSegmentProducer throws an exception in 12_2_X because it is using a deprecated pattern of getting data from EventSetup (EventSetup without ESGetToken). Then, this PR migrate to using recommended one. (EventSetup with ESGetToken)

[perrotta]

please test

[perrotta]

ping bot

[qliphy]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-054fa3/23433/summary.html
COMMIT: cc3d2b6
CMSSW: CMSSW_12_2_X_2022-03-27-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37341/23433/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 3251324
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3251296
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
• Checked 177 log files, 37 edm output root files, 42 DQM output files
• TriggerResults: no differences found

[srimanob]

+Upgrade

This is a needed backport for GEMCSCSegmentProducer in 12_2 release.

[perrotta]

backport of #36628

[jpata]

+reconstruction

• exact backport of Migrate to EventSetup with ESGetToken in GEMCSCSegmentProducer #36628
• no changes

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

• Technical update meant to backport an updated DQM monitoring for the GEM: it does not affects reco outputs.