CMSSW_12_2_X: Fix crash in the trigger table view controllers

[alja]

Correctly detect string type setters in auto generated controller GUI.

[alja]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_2_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

A new Pull Request was created by @alja (Alja Mrak Tadel) for CMSSW_12_2_X.

It involves the following packages:

• Fireworks/Core (visualization)

can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from [Fireworks master] Correctly handle string type in FWParameterSetterBase::makeSetterFor() #37350

[perrotta]

backport of #37350

[perrotta]

@alja if you want to backport in 12_2, please also provide a backport for the intermediate cycle (between 12_2 and the master 12_4) CMSSW_12_3_X

[alja]

@perrotta The CMSSW_12_3_X needs the correction too. Do I need to create a PR for this as well?

[perrotta]

@perrotta The CMSSW_12_3_X needs the correction too. Do I need to create a PR for this as well?

yes, please

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b5c284/23401/summary.html
COMMIT: 2e29561
CMSSW: CMSSW_12_2_X_2022-03-25-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37349/23401/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 3251324
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3251302
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
• Checked 177 log files, 37 edm output root files, 42 DQM output files
• TriggerResults: no differences found

[qliphy]

+1