[12_2_X] Fix tag names in DQM Fake BeamSpot clients

[francescobrivio]

PR description:

Backport of #37376
Following the discussion with BeamSpot/DB/HLT/DAQ experts, in order to stress test the system and prove that the coral patch works we need to re-deploy in production the fake BeamSpot DQM clients that create fake (TRandom) BeamSpot values and upload them to the DB. This will not affect data quality in any way since the fake clients will be deployed only during cosmics, when the beamspot is not really used/useful in any case.

In order not to pollute the production tags with "fake" BeamSpot payloads, this PR changes the name of the output tag to which the payloads are uploaded to. The tag name changes are:

• BeamSpotOnlineLegacy --> BeamSpotOnlineFakeLegacy
• BeamSpotOnlineHLT --> BeamSpotOnlineFakeHLT

PR validation:

Code compiles.
Should be tested in online DQM machines.

Backport:

Backport of #37376

[cmsbuild]

A new Pull Request was created by @francescobrivio for CMSSW_12_2_X.

It involves the following packages:

• DQM/Integration (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@threus, @batinkov, @battibass this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from Fix tag names in DQM Fake BeamSpot clients #37376

[francescobrivio]

backport of #37376

[francescobrivio]

@cmsbuild please test

[francescobrivio]

@cms-sw/dqm-l2 this PR should be tested in P5 DQM machines.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b38bf9/23451/summary.html
COMMIT: d5158c3
CMSSW: CMSSW_12_2_X_2022-03-28-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37379/23451/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 3251324
• DQMHistoTests: Total failures: 11
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3251290
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 41 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 177 log files, 37 edm output root files, 42 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1
Tested successfully in Online DQM at P5

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[francescobrivio]

+1 Tested successfully in Online DQM at P5

Thanks @jfernan2!
I just had a look at the playback that tested this PR (https://cmsweb.cern.ch/dqm/dqm-square/tmp/content_parser_playbackPARSER_run503350 IIUC) and realized that in the playback the fake beam clients (which are modified in this PR) weren't run, only the "standard" ones were running. I don't foresee any issue, but would you mind re-running the playback with the beamhlt and beamfakehlt clients as well? just to be double-sure... 😄
And sorry for not noticing before!

FYI @cms-sw/dqm-l2

[pmandrik]

Dear @francescobrivio ,

we did not run fake beam clients for a while since the request for decommission and now they crash for pp_run & cosmic_run keys, please find the logs here:
https://cmsweb.cern.ch/dqm/dqm-square/tmp/content_parser_playbackPARSER_job1.log
https://cmsweb.cern.ch/dqm/dqm-square/tmp/content_parser_playbackPARSER_job8.log

Best regards, Petr

[francescobrivio]

Dear @francescobrivio ,

we did not run fake beam clients for a while since the request for decommission and now they crash for pp_run & cosmic_run keys, please find the logs here: https://cmsweb.cern.ch/dqm/dqm-square/tmp/content_parser_playbackPARSER_job1.log https://cmsweb.cern.ch/dqm/dqm-square/tmp/content_parser_playbackPARSER_job8.log

Best regards, Petr

Thanks @pmandrik I'll take a look asap!

[jfernan2]

-1

[francescobrivio]

@pmandrik @jfernan2
Ok the issue should be understood and fixed now: this PR updates also the "JobName" which, for security reasons of the DB, has to be manually inserted into the allowed names. Now @ggovi has added the two new names:

• BeamSpotOnlineFakeLegacy
• BeamSpotOnlineFakeHLT

@pmandrik please, when you can, try again the playback! Thanks!

[pmandrik]

Hi, @francescobrivio , the error is the same, please check:
https://cmsweb.cern.ch/dqm/dqm-square/tmp/content_parser_playbackPARSER_job1.log
https://cmsweb.cern.ch/dqm/dqm-square/tmp/content_parser_playbackPARSER_job8.log

P.S. maybe the job names are (following the printout in the logs):
BeamSpotOnlineFakeLegacyPlayback
BeamSpotOnlineFakeHLTPlayback

[francescobrivio]

Hi, @francescobrivio , the error is the same, please check: https://cmsweb.cern.ch/dqm/dqm-square/tmp/content_parser_playbackPARSER_job1.log https://cmsweb.cern.ch/dqm/dqm-square/tmp/content_parser_playbackPARSER_job8.log

P.S. maybe the job names are (following the printout in the logs): BeamSpotOnlineFakeLegacyPlayback BeamSpotOnlineFakeHLTPlayback

Hi @pmandrik, indeed you are right!
We have now added the two new job names that you suggested, so please try one more time! Thanks a lot!

[pmandrik]

Thanks, now the fake beam clients run without crashes.

[francescobrivio]

Perfect! thanks a lot for the patience @pmandrik!
@jfernan2 feel free to sign this now that everything looks ok!

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1