Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport extended exception for geant4/vecgeom tracking #37381

Merged
merged 1 commit into from Mar 29, 2022

Conversation

civanch
Copy link
Contributor

@civanch civanch commented Mar 28, 2022

PR description:

Backport extended handling of Geant4/VecGeom exceptions from the master in order to address #37373. Here only files are backported from #36717 and #37216 with modifications of code for exceptions. Geant4 trace of exceptions expected with the new Geant4 11.0 is not considered.

PR validation:

private

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for CMSSW_12_2_X.

It involves the following packages:

  • SimG4Core/Application (simulation)

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @cvuosalo, @rovere, @bsunanda, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@civanch
Copy link
Contributor Author

civanch commented Mar 28, 2022

please test

@perrotta
Copy link
Contributor

This PR backports a subset of #36717, and its fixes in #37216
@civanch could you please explain in the description what you are backporting here from #36717, and why you are not proposing to backport it all?

A comment about the previous decision of not backporting those two PRs in 12_2_X was written in #36780 (comment)

@mmusich
Copy link
Contributor

mmusich commented Mar 28, 2022

@civanch is this supposed to fix #37373 ?

@civanch
Copy link
Contributor Author

civanch commented Mar 28, 2022

I have tried to extend the description.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-966e5b/23452/summary.html
COMMIT: bba73af
CMSSW: CMSSW_12_2_X_2022-03-28-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37381/23452/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 3251324
  • DQMHistoTests: Total failures: 11
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3251290
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 41 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor Author

civanch commented Mar 28, 2022

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@civanch
Copy link
Contributor Author

civanch commented Mar 28, 2022

urgent

@qliphy
Copy link
Contributor

qliphy commented Mar 29, 2022

@civanch In the description, the issue mentioned should be #37373 instead of #37343

@qliphy
Copy link
Contributor

qliphy commented Mar 29, 2022

+1

@cmsbuild cmsbuild merged commit cd33eab into cms-sw:CMSSW_12_2_X Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants