L1 phase-2 calo developments

[cecilecaillol]

PR description:

This is another PR to port all L1T Phase-2 developments to cms-sw. This PR targets the calorimeter code. It includes several PRs made locally, the details of which can be found in the twiki https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideL1TPhase2Instructions and in the cms-l1t-offline branch.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37401/29065

• This PR adds an extra 56KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File L1Trigger/L1CaloTrigger/plugins/L1TowerCalibrator.cc modified in PR(s): Run3-gex124C Try to avoid compilation warnings in L1Trigger/L1CaloTrigger #37353
  • File L1Trigger/L1CaloTrigger/plugins/Phase1L1TJetSumsProducer.cc modified in PR(s): Run3-gex124C Try to avoid compilation warnings in L1Trigger/L1CaloTrigger #37353
  • File L1Trigger/L1CaloTrigger/test/ntuples/L1TriggerNtupleTrackTrigger.cc modified in PR(s): Run3-gex124C Try to avoid compilation warnings in L1Trigger/L1CaloTrigger #37353

[cmsbuild]

A new Pull Request was created by @cecilecaillol for master.

It involves the following packages:

• L1Trigger/L1CaloTrigger (upgrade, l1)

@rekovic, @epalencia, @cmsbuild, @AdrianoDee, @srimanob, @cecilecaillol can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cecilecaillol]

please test

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-61c0e0/23503/summary.html
COMMIT: 97c9b86
CMSSW: CMSSW_12_4_X_2022-03-29-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37401/23503/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test test-das-selected-lumis had ERRORS

Comparison Summary

Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 2848846
• DQMHistoTests: Total failures: 12
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2848812
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 40 files compared)
• Checked 186 log files, 43 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[cecilecaillol]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-61c0e0/23518/summary.html
COMMIT: 97c9b86
CMSSW: CMSSW_12_4_X_2022-03-29-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37401/23518/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 2848846
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2848818
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 40 files compared)
• Checked 186 log files, 43 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[cecilecaillol]

+l1

[AdrianoDee]

Do we really need these? I mean: it's useful because a switch between the two may be done in the future? If not I would remove them.

[AdrianoDee]

@cecilecaillol it seems there are some conflicts to be solved. Excluding that and a very minor comment it is good to go for me.

A general question about these L1 PRs to fill for my ignorance: there's no way (a wf) to test these changes in the release, is it?

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37401/29248

• This PR adds an extra 24KB to repository

[cmsbuild]

Pull request #37401 was updated. @rekovic, @epalencia, @cmsbuild, @AdrianoDee, @srimanob, @cecilecaillol can you please check and sign again.

[cecilecaillol]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-61c0e0/23832/summary.html
COMMIT: 437cc15
CMSSW: CMSSW_12_4_X_2022-04-11-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37401/23832/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3593039
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3593009
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 200 log files, 45 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[perrotta]

Thank you @EmyrClement and @cecilecaillol: all eta ranges seem to be mapped now

[cecilecaillol]

+l1

[srimanob]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1