Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning: 'mzbtemp' may be used uninitialized #37408

Merged
merged 1 commit into from Mar 30, 2022

Conversation

iarspider
Copy link
Contributor

PR description:

This PR fixes the following warning seen in PPC builds:

/scratch/cmsbuild/jenkins_a/workspace/build-any-ib/w/tmp/BUILDROOT/ec2e2d6b67708ad491c755cf4edb383f/opt/cmssw/slc7_ppc64le_gcc11/cms/cmssw/CMSSW_12_4_X_2022-03-29-2300/src/L1Trigger/L1TTrackMatch/plugins/L1TrackJetProducer.cc: In member function 'void L1TrackJetProducer::L2_cluster(std::vector<edm::Ptr<TTTrack<edm::Ref<edm::DetSetVector<Phase2TrackerDigi>, Phase2TrackerDigi> > > >, std::vector<int>, MaxZBin&)':
  /scratch/cmsbuild/jenkins_a/workspace/build-any-ib/w/tmp/BUILDROOT/ec2e2d6b67708ad491c755cf4edb383f/opt/cmssw/slc7_ppc64le_gcc11/cms/cmssw/CMSSW_12_4_X_2022-03-29-2300/src/L1Trigger/L1TTrackMatch/plugins/L1TrackJetProducer.cc:250:18: warning: 'mzbtemp' may be used uninitialized [-Wmaybe-uninitialized]
   250 |     all_zBins[z] = mzbtemp;
      |     ~~~~~~~~~~~~~^~~~~~~~~
/scratch/cmsbuild/jenkins_a/workspace/build-any-ib/w/tmp/BUILDROOT/ec2e2d6b67708ad491c755cf4edb383f/opt/cmssw/slc7_ppc64le_gcc11/cms/cmssw/CMSSW_12_4_X_2022-03-29-2300/src/L1Trigger/L1TTrackMatch/plugins/L1TrackJetProducer.cc:248:11: note: 'mzbtemp' declared here
  248 |   MaxZBin mzbtemp;
      |           ^~~~~~~

@cmsbuild cmsbuild added this to the CMSSW_12_4_X milestone Mar 30, 2022
@iarspider
Copy link
Contributor Author

please test for slc7_ppc64le_gcc11

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37408/29072

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for master.

It involves the following packages:

  • L1Trigger/L1TTrackMatch (upgrade, l1)

@epalencia, @AdrianoDee, @srimanob, @cecilecaillol, @rekovic can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7a6977/23519/summary.html
COMMIT: 9f7c8a1
CMSSW: CMSSW_12_4_X_2022-03-29-2300/slc7_ppc64le_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37408/23519/install.sh to create a dev area with all the needed externals and cmssw changes.

@cecilecaillol
Copy link
Contributor

+l1

@srimanob
Copy link
Contributor

+Upgrade

Technical PR.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 8aa9d30 into cms-sw:master Mar 30, 2022
@perrotta
Copy link
Contributor

ping bot

@iarspider iarspider deleted the fix-maxzbin-uninitialized branch March 30, 2022 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants