Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable concurrent IOVs by default in ConfigBuilder #37419

Merged
merged 1 commit into from Apr 1, 2022

Conversation

makortel
Copy link
Contributor

PR description:

While investigating #37385 / #37417 I noticed the default value in ConfigBuilder for the number of concurrent IOVs was still 1. I was supposed to change this to 0 at the time as #35302 that followed the default value logic addition to cmsRun directly in #34231. This PR sets the default value to 0, which means that the number of concurrent IOVs is set to be the same as the number of concurrent lumis.

For future reference, the main concern at the time was the memory usage of the additional per-lumi EventSetup products, which was concluded to be small in #33436.

PR validation:

Limited matrix (plus some more) runs multithreaded

I was supposed to do this at the same time as
cms-sw#35302
that followed
cms-sw#34231
and the conclusion in
cms-sw#33436
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37419/29096

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

  • Configuration/Applications (operations)

@cmsbuild, @perrotta, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

enable threading

@makortel
Copy link
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-06cef5/23569/summary.html
COMMIT: 054a62f
CMSSW: CMSSW_12_4_X_2022-03-31-1100/slc7_amd64_gcc10
Additional Tests: THREADING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37419/23569/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3591311
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3591287
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 200 log files, 45 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

perrotta commented Apr 1, 2022

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit ac2aa35 into cms-sw:master Apr 1, 2022
@makortel makortel deleted the concurrentIOVConfigBuilder branch April 1, 2022 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants