Fixing FastTimerClient Hist Remaking Issue : 12_3_X

[Sam-Harper]

PR description:

This is the bug fix backport of #37402

Before the path of the histogram was not specified when checking it exists leading to the histogram being remade over and over which is a very expensive operation.

It also adds an option to disable making the histograms every lumisection which is the desired behaviour for everything expect online workflows.

PR validation:

see: #37402

if this PR is a backport please specify the original PR and why you need to backport that PR:

#37402

This fix is necessary to be able to harvest timing jobs running on multiple lumisections (which is our current workflow when reemulating the L1 running on ZB). Otherwise the job will take hours rather than seconds.

[cmsbuild]

A new Pull Request was created by @Sam-Harper (Sam Harper) for CMSSW_12_3_X.

It involves the following packages:

• HLTrigger/Timer (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from Fixing FastTimerClient Hist Remaking Issue : 12_4_X #37402

[missirol]

backport of #37402

[missirol]

type bugfix

[missirol]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-36b4a1/23567/summary.html
COMMIT: 4b84728
CMSSW: CMSSW_12_3_X_2022-03-31-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37421/23567/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3697381
• DQMHistoTests: Total failures: 14
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3697345
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 204 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[missirol]

+hlt

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1