Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GEM] bugfix - BC and OrbitCounter in AMC13 - backport #37423

Merged
merged 2 commits into from Apr 4, 2022

Conversation

jshlee
Copy link
Contributor

@jshlee jshlee commented Mar 31, 2022

backport of #37340

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 31, 2022

A new Pull Request was created by @jshlee (Jason Lee) for CMSSW_12_2_X.

It involves the following packages:

  • DataFormats/GEMDigi (upgrade, simulation)

@cmsbuild, @AdrianoDee, @srimanob, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@giovanni-mocellin, @rovere, @watson-ij, @eyigitba this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@jshlee
Copy link
Contributor Author

jshlee commented Mar 31, 2022

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e897ad/23573/summary.html
COMMIT: 586dd77
CMSSW: CMSSW_12_2_X_2022-03-31-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37423/23573/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 3251324
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3251302
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@srimanob
Copy link
Contributor

+Upgrade

Backport.

@civanch
Copy link
Contributor

civanch commented Apr 4, 2022

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Apr 4, 2022

+1

@cmsbuild cmsbuild merged commit 44941d8 into cms-sw:CMSSW_12_2_X Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants