Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AlCaLumiPixels_Run3 scenario #37434

Merged
merged 2 commits into from Apr 5, 2022
Merged

Conversation

tvami
Copy link
Contributor

@tvami tvami commented Apr 1, 2022

PR description:

AlCaLumiPixels scenario was never moved to Run-3, so this PR does that.

PR validation:

scram b runtests runs fine with the modified unit test.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Probably we need it in 12_3_X

@tvami
Copy link
Contributor Author

tvami commented Apr 1, 2022

type bug-fix

@tvami
Copy link
Contributor Author

tvami commented Apr 1, 2022

attn @cms-sw/alca-l2 @benitezj

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37434/29130

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2022

A new Pull Request was created by @tvami (Tamas Vami) for master.

It involves the following packages:

  • Configuration/DataProcessing (operations)

@cmsbuild, @perrotta, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor Author

tvami commented Apr 1, 2022

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a4c6ff/23606/summary.html
COMMIT: 18db5e5
CMSSW: CMSSW_12_4_X_2022-04-01-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37434/23606/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3593039
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3593015
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 200 log files, 45 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor Author

tvami commented Apr 1, 2022

So this is an operations-l2 only signature, @cms-sw/orp-l2 do you have any comments?

@perrotta
Copy link
Contributor

perrotta commented Apr 4, 2022

@tvami this is just the configuration that allows addiing that scenario: where it is actually implemented?

@tvami
Copy link
Contributor Author

tvami commented Apr 4, 2022

@tvami this is just the configuration that allows addiing that scenario: where it is actually implemented?

Hi @perrotta , nowhere yet, it will be here:
https://github.com/dmwm/T0/blob/5f7a3489851455d8bd6faa04288f36ce04d2eba5/etc/ReplayOfflineConfiguration.py#L117
once we have a new CMSSW out (I guess at this point I can also say that we'll need a new 12_3_X CMSSW to finally test this)

@perrotta
Copy link
Contributor

perrotta commented Apr 4, 2022

Thank you @tvami
Then, how are we supposed to validate this config? Was it ever tried at T0? Or should we just wait for that possible future CMSSW release to be run at T0?

@tvami
Copy link
Contributor Author

tvami commented Apr 4, 2022

This is a long ongoing issue, that we can't test stuff at T0 w/o having a pre-(or full)release. The T0 team is working on having some workaround for a while now, but I don't think there is anything yet.

This PR
dmwm/T0#4650
was testing with the AlCaLumiPixels scenario, when we have a new CMSSW I'll change that to AlCaLumiPixels_Run3 scenario

@davidlange6
Copy link
Contributor

why does the t0 needed for testing ? The unit tests of Config/DataProcessing ought to do the initial sanity test that the configuration is sane and runs.

@tvami
Copy link
Contributor Author

tvami commented Apr 4, 2022

The unit tests of Config/DataProcessing ought to do the initial sanity test that the configuration is sane and runs.

OK then, that did pass, right?

@davidlange6
Copy link
Contributor

davidlange6 commented Apr 4, 2022 via email

@perrotta
Copy link
Contributor

perrotta commented Apr 4, 2022

Thank you @davidlange6 for the suggestion, and @tvami for the implementation!

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37434/29155

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2022

Pull request #37434 was updated. @cmsbuild, @perrotta, @qliphy, @fabiocos, @davidlange6 can you please check and sign again.

@tvami
Copy link
Contributor Author

tvami commented Apr 4, 2022

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a4c6ff/23643/summary.html
COMMIT: 249c205
CMSSW: CMSSW_12_4_X_2022-04-04-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37434/23643/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3593039
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3593015
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 200 log files, 45 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor Author

tvami commented Apr 4, 2022

@perrotta
Copy link
Contributor

perrotta commented Apr 5, 2022

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants