New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AlCaLumiPixels_Run3 scenario #37434
Conversation
type bug-fix |
attn @cms-sw/alca-l2 @benitezj |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37434/29130
|
A new Pull Request was created by @tvami (Tamas Vami) for master. It involves the following packages:
@cmsbuild, @perrotta, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild , please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a4c6ff/23606/summary.html Comparison SummarySummary:
|
So this is an |
@tvami this is just the configuration that allows addiing that scenario: where it is actually implemented? |
Hi @perrotta , nowhere yet, it will be here: |
Thank you @tvami |
This is a long ongoing issue, that we can't test stuff at T0 w/o having a pre-(or full)release. The T0 team is working on having some workaround for a while now, but I don't think there is anything yet. This PR |
why does the t0 needed for testing ? The unit tests of Config/DataProcessing ought to do the initial sanity test that the configuration is sane and runs. |
OK then, that did pass, right? |
it of course has to be tweaked for the specific change introduced...
… On Apr 4, 2022, at 3:46 PM, Tamas Vami ***@***.***> wrote:
The unit tests of Config/DataProcessing ought to do the initial sanity test that the configuration is sane and runs.
OK then, that did pass, right?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.
|
Thank you @davidlange6 for the suggestion, and @tvami for the implementation! |
f401eb3
to
002628e
Compare
002628e
to
249c205
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37434/29155
|
@cmsbuild , please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a4c6ff/23643/summary.html Comparison SummarySummary:
|
@perrotta ok the unit test seems to be working fine: |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
AlCaLumiPixels scenario was never moved to Run-3, so this PR does that.
PR validation:
scram b runtests
runs fine with the modified unit test.if this PR is a backport please specify the original PR and why you need to backport that PR:
Probably we need it in 12_3_X