Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_3_X] Fix xml tag in PPS strips mapping #37450

Merged
merged 1 commit into from Apr 5, 2022

Conversation

ChrisMisan
Copy link
Contributor

PR description:

PR adds a missing closing tag to the strips xml mapping.

PR validation:

relvals 136.793, 136.874

if this PR is a backport please specify the original PR and why you need to backport that PR:

original PR #37449

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2022

A new Pull Request was created by @ChrisMisan (Christopher) for CMSSW_12_3_X.

It involves the following packages:

  • CondFormats/PPSObjects (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@grzanka, @mmusich, @seemasharmafnal, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@francescobrivio
Copy link
Contributor

type bugfix

@francescobrivio
Copy link
Contributor

backport of #37449

@francescobrivio
Copy link
Contributor

test parameters:

  • workflows = 136.793, 136.874

@francescobrivio
Copy link
Contributor

@cmsbuild please test

@francescobrivio
Copy link
Contributor

francescobrivio commented Apr 3, 2022

@ChrisMisan thanks for this backport! Could you please add "[12_3_X]" in the title? And please mention in the title that these are the PPS strips, not the SiStrips :) (also for the master PR)

@ChrisMisan ChrisMisan changed the title Fix xml tag in strips mapping [12_3_X] Fix xml tag in strips mapping Apr 3, 2022
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eadfe1/23630/summary.html
COMMIT: 8de5a3c
CMSSW: CMSSW_12_3_X_2022-04-03-0000/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37450/23630/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3697381
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3697357
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Apr 3, 2022

+alca

  • Jenkins diffs are known

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@tvami
Copy link
Contributor

tvami commented Apr 3, 2022

@ChrisMisan

And please mention in the title that these are the PPS strips, not the SiStrips :) (also for the master PR)

@ChrisMisan ChrisMisan changed the title [12_3_X] Fix xml tag in strips mapping [12_3_X] Fix xml tag in PPS strips mapping Apr 3, 2022
@qliphy
Copy link
Contributor

qliphy commented Apr 5, 2022

+1

@cmsbuild cmsbuild merged commit 6e4ac3f into cms-sw:CMSSW_12_3_X Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants