minor changes to SiPixelLorentzAnglePCL modules

[mmusich]

PR description:

The goal of this PR is to introduce few minor improvements to the SiPixelLorentzAnglePCL modules:

• loosen the cluster size cut on BPix L2 from 4 to 3, as per presentation at AlCa/DB meeting Mar 28^th;
• zero the errors in several per sector monitor elements (to ease comparison using DQM GUI);
• avoid bounds checks in array access to speed-up computations;
• shorten per-sector bin names;
• reset ME h_drift_depth_adc_slice_ after computation is done;

PR validation:

Private tests to be completed.

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

cc:
@wweiphy

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37455/29149

• This PR adds an extra 28KB to repository

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

• CalibTracker/SiPixelLorentzAngle (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@tocheng, @OzAmram, @ferencek, @mmusich, @dkotlins, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-59d63d/23640/summary.html
COMMIT: 51c495b
CMSSW: CMSSW_12_4_X_2022-04-04-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37455/23640/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3593039
• DQMHistoTests: Total failures: 46
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3592970
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 47 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 200 log files, 45 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[francescobrivio]

+alca

• PR in line with description
• differences in the testes are only in the SiPixelLorentzAngle wf as expected

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[francescobrivio]

@mmusich do you think a 12_3_X backport would be useful? There are still some days before 12_3_0 is built and deployed in Tier0.

[mmusich]

do you think a 12_3_X backport would be useful?

sure, will do.

[mmusich]

here it is: #37459

[perrotta]

@mmusich @francescobrivio there are quite a lot differences in the DQM outputs of wf 1001, see a few examples below:

Are they justified by the changes applied in this PR?
Why only in that PR, and not for example in 138.5 for Run3?

[mmusich]

Are they justified by the changes applied in this PR?

Yes.

Why only in that PR, and not for example in 138.5 for Run3?

Because 1001.0 is the only wf that runs PCL in the short matrix ( as stale as the input data might be)

[perrotta]

+1