Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clang warning in HcalAlCaRecoProducers. #3746

Merged
merged 1 commit into from May 8, 2014
Merged

Fix clang warning in HcalAlCaRecoProducers. #3746

merged 1 commit into from May 8, 2014

Conversation

ghost
Copy link

@ghost ghost commented May 8, 2014

No description provided.

@ghost ghost added alca-pending labels May 8, 2014
@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2014

A new Pull Request was created by @Degano (Alessandro Degano) for CMSSW_7_1_X.

Fix clang warning in HcalAlCaRecoProducers.

It involves the following packages:

Calibration/HcalAlCaRecoProducers

@cmsbuild, @Degano, @diguida, @rcastello, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

static const unsigned int nL1trg = 200;

static const unsigned int nL1mx=140;
static const unsigned int nHLTmx=140;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused variables, I'd say...

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2014

@ghost ghost added alca-pending labels May 8, 2014
@diguida
Copy link
Contributor

diguida commented May 8, 2014

+1
Unused static const global variables for AlCaHOCalibProducer.

@ghost ghost added alca-approved labels May 8, 2014
@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

@ghost ghost added alca-approved labels May 8, 2014
ktf added a commit that referenced this pull request May 8, 2014
Clang -- Fix warning in HcalAlCaRecoProducers.
@ktf ktf merged commit 11b26d6 into cms-sw:CMSSW_7_1_X May 8, 2014
@ghost ghost deleted the fix_warn_clang_hcalalcareco_71X branch May 15, 2014 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants