[Backport of] HCAL: fix on HCAL TP saturation algorithm to synchronize s/w TP algorithm with f/w

[TaeunKwon]

PR description:

This PR updates the HCAL Trigger Primitive(TP) reconstruction algorithm to synchronize s/w TP algorithm with f/w TP algorithm. Recently, PR updating TP algorithm to recover a saturation threshold for HE with |ieta| >= 21 in PR #37196 was submitted. However, we want the PR #37196 to be reverted since it is not yet implemented in f/w and we need matches between s/w and f/w in production release now. The comparison between recontructed TP energy with MAHI rechit energy was performed and can be found in this slide. The problem of the sharp cutoff at 64 GeV in HE(|ieta| >= 21) is well understood now, and TP algorithm will be updated both in f/w and s/w to recover the same TP energy threshold of 128 GeV in HE(|ieta| >= 21) in later PR.

PR validation:

A basic technical test was performed in CMSSW_12_3_X_2022-04-05-1100 : runTheMatrix.py -l limited -i all --ibeos

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is a backport of PR #37471 to 123X, as we need matches between s/w and f/w in production release now.

[cmsbuild]

A new Pull Request was created by @TaeunKwon for CMSSW_12_3_X.

It involves the following packages:

• SimCalorimetry/HcalTrigPrimAlgos (l1)

@epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please review it and eventually sign? Thanks.
@bsunanda, @abdoulline, @rovere this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from HCAL: fix on HCAL TP saturation algorithm to synchronize s/w TP algorithm with f/w #37471

[epalencia]

Please test

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b271ba/23674/summary.html
COMMIT: c46bab0
CMSSW: CMSSW_12_3_X_2022-04-05-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37472/23674/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

• 1348.01348.0_EtaBToJpsiJpsi_13+EtaBToJpsiJpsi_13INPUT+DIGIUP15+RECOUP15+HARVESTUP15/step2_EtaBToJpsiJpsi_13+EtaBToJpsiJpsi_13INPUT+DIGIUP15+RECOUP15+HARVESTUP15.log
• 200.0200.0_ZEE+ZEEINPUT+DIGIPU1+RECOPU1+HARVEST/step2_ZEE+ZEEINPUT+DIGIPU1+RECOPU1+HARVEST.log
• 4002.04002.0_ZEE+ZEEINPUT+DIGI+RECO/step2_ZEE+ZEEINPUT+DIGI+RECO.log

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3697381
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3697351
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 48 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 204 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[cecilecaillol]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b271ba/23686/summary.html
COMMIT: c46bab0
CMSSW: CMSSW_12_3_X_2022-04-05-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37472/23686/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3697381
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3697357
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 204 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[cecilecaillol]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

backport of #37471

[perrotta]

+1

• Exact backport of what is merged in the master after the integration of HCAL: fix on HCAL TP saturation algorithm to synchronize s/w TP algorithm with f/w #37471, successfully running in the IB's since CMSSW_12_4_X_2022-04-07-1100