[CS9] Remove usage of deprecated SHA1 functions, use EVP_Digest instead

[smuzaffar]

For CS9 IB, where OpenSSL version 3.0, we have a lot of warning about deprecated use of SHA1_* functions [a]. OpenSSL recommends to use EVP_Digest* instead [b].

This PR updates OnlineDB/SiStripO2O package (where we have 88 warnings in cs9 Ibs) to use EVP_Digest* . Also unit tests are added to test old SHA1_* and new EVP_Digest*.

[a] https://www.openssl.org/docs/manmaster/man3/SHA1_Init.html

[b]

All of the functions described on this page except for SHA1(), SHA224(), SHA256(), SHA384() and SHA512() are
deprecated. Applications should instead use EVP_DigestInit_ex(3), EVP_DigestUpdate(3) , EVP_DigestFinal_ex(3)
or the quick one-shot function EVP_Q_digest(3)

[smuzaffar]

@cms-sw/db-l2 , looks like there are no unit test to test OnlineDB/SiStripO2O package. Can you please add some unit test for this package?

[tvami]

@cms-sw/db-l2 , looks like there are no unit test to test OnlineDB/SiStripO2O package. Can you please add some unit test for this package?

@quinnanm would you please give this a try? Thanks!

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37490/29192

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

• OnlineDB/SiStripO2O (db)
• Utilities/General (core)

@smuzaffar, @Dr15Jones, @malbouis, @makortel, @cmsbuild, @ggovi, @tvami, @francescobrivio can you please review it and eventually sign? Thanks.
@erikbutz, @mmusich, @wddgit this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

test parameters:

• addpkg = CondTools/SiStrip

[mmusich]

There are some O2O-related unit tests in CondTools/SiStrip:

cmssw/CondTools/SiStrip/test/BuildFile.xml

Lines 5 to 6 in 31d7275

	<test name="SiStripDCS_O2O_test" command="testSiStripDCSO2O.sh"/>
	<test name="SiStripDAQ_O2O_test" command="testSiStripDAQO2O.sh"/>

[tvami]

@cmsbuild , please test for cs9_amd64_gcc11

[smuzaffar]

please test
lets also start the tests for production arch as compilation looks good for cs9 ( no warnings: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f2b470/23731/build-logs/ ) .

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f2b470/23732/summary.html
COMMIT: 4591bf3
CMSSW: CMSSW_12_4_X_2022-04-07-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37490/23732/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3593039
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3593015
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 200 log files, 45 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[tvami]

@cmsbuild , please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f2b470/23750/summary.html
COMMIT: 4591bf3
CMSSW: CMSSW_12_4_X_2022-04-07-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37490/23750/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3593039
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3593009
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 47 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 200 log files, 45 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f2b470/23731/summary.html
COMMIT: 4591bf3
CMSSW: CMSSW_12_4_X_2022-04-06-2300/cs9_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37490/23731/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 66032 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3593039
• DQMHistoTests: Total failures: 423032
• DQMHistoTests: Total nulls: 281
• DQMHistoTests: Total successes: 3169704
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.6560000000000001 KiB( 47 files compared)
• DQMHistoSizes: changed ( 10224.0 ): 0.975 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 11834.0 ): 0.996 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 136.874,... ): 0.004 KiB MessageLogger/Warnings
• DQMHistoSizes: changed ( 25202.0 ): -0.054 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 7.3 ): -0.269 KiB SiStrip/MechanicalView
• Checked 200 log files, 45 edm output root files, 48 DQM output files

[tvami]

+db

• tests pass, scl7 diffs are known
• cs9 compiles and runs
• unit tests pass
• I tested privately the O2O script, that works as well

[makortel]

+core

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1