Run3-alca222 Update some of the macros usedin calibrating HCAL with isotrack or muon #37504

bsunanda · 2022-04-08T10:34:50Z

PR description:

Update some of the macros usedin calibrating HCAL with isotrack or muon

PR validation:

Tested with studies of 2018 data calibration

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

cmsbuild · 2022-04-08T10:41:27Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37504/29212

This PR adds an extra 44KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37504/29212/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37504/29212/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2022-04-08T10:56:58Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37504/29214

This PR adds an extra 44KB to repository

cmsbuild · 2022-04-08T10:57:18Z

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

Calibration/HcalCalibAlgos (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

tvami · 2022-04-08T12:27:50Z

Calibration/HcalCalibAlgos/macros/PlotMPV.C

@@ -675,7 +691,8 @@ void getTruncatedMeanX(
        log << type << '\t' << ieta[k] << '\t' << phi << '\t' << depth << '\t' << nvx << '\t' << rt.mean << '\t'
            << rt.error << std::endl;
        if (save) {
-          sprintf(name, "%s_comb.pdf", rt.pad->GetName());
+          //        sprintf(name, "%s_comb.pdf", rt.pad->GetName());


please remove the commented out code, also true in line 675-676

tvami · 2022-04-08T12:28:27Z

Calibration/HcalCalibAlgos/macros/PlotMPV.C

+  int k0 = (year == 17) ? 11 : 0;
+  for (int k = k0; k < 22; ++k) {


maybe the 11 and 22 could be made a named constant?

tvami · 2022-04-08T12:34:13Z

Hi @bsunanda do you need this for low PU stable collisions in June? If yes, you should do a backport to 12_3_X as well (after this PR merged)

cmsbuild · 2022-04-09T01:45:08Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37504/29223

This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37504/29223/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37504/29223/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

bsunanda · 2022-04-09T01:55:11Z

@cmsbuild Please test

cmsbuild · 2022-04-09T01:57:34Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37504/29225

This PR adds an extra 20KB to repository

cmsbuild · 2022-04-09T01:57:56Z

Pull request #37504 was updated. @malbouis, @tvami, @yuanchao, @francescobrivio can you please check and sign again.

cmsbuild · 2022-04-09T08:32:41Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6898ab/23784/summary.html
COMMIT: 0d620ba
CMSSW: CMSSW_12_4_X_2022-04-08-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37504/23784/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 9 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3593039
DQMHistoTests: Total failures: 19
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3592997
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 47 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 200 log files, 45 edm output root files, 48 DQM output files
TriggerResults: no differences found

tvami · 2022-04-09T14:22:08Z

+alca

diffs in MsgLogger only

cmsbuild · 2022-04-09T14:22:31Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2022-04-10T01:57:56Z

+1

Update some of the macros usedin calibrating HCAL with isotrack or muon

59b457c

cmsbuild added this to the CMSSW_12_4_X milestone Apr 8, 2022

cmsbuild added alca-pending code-checks-pending orp-pending pending-signatures tests-pending labels Apr 8, 2022

cmsbuild added code-checks-rejected and removed code-checks-pending labels Apr 8, 2022

Code check

cfef813

cmsbuild added code-checks-pending and removed code-checks-rejected labels Apr 8, 2022

bsunanda changed the title ~~un3-alca222 Update some of the macros usedin calibrating HCAL with isotrack or muon~~ Run3-alca222 Update some of the macros usedin calibrating HCAL with isotrack or muon Apr 8, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 8, 2022

tvami reviewed Apr 8, 2022

View reviewed changes

Take care of Tamas's comments

26def1e

cmsbuild added code-checks-pending and removed code-checks-approved labels Apr 9, 2022

cmsbuild added code-checks-rejected and removed code-checks-pending labels Apr 9, 2022

Code check

0d620ba

cmsbuild added code-checks-pending and removed code-checks-rejected labels Apr 9, 2022

cmsbuild added tests-started and removed tests-pending labels Apr 9, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 9, 2022

cmsbuild added tests-approved and removed tests-started labels Apr 9, 2022

cmsbuild added alca-approved fully-signed and removed alca-pending pending-signatures labels Apr 9, 2022

cmsbuild added orp-approved and removed orp-pending labels Apr 10, 2022

cmsbuild merged commit d40f999 into cms-sw:master Apr 10, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Run3-alca222 Update some of the macros usedin calibrating HCAL with isotrack or muon #37504

Run3-alca222 Update some of the macros usedin calibrating HCAL with isotrack or muon #37504

bsunanda commented Apr 8, 2022

cmsbuild commented Apr 8, 2022

cmsbuild commented Apr 8, 2022

cmsbuild commented Apr 8, 2022

tvami Apr 8, 2022

tvami Apr 8, 2022

tvami commented Apr 8, 2022

cmsbuild commented Apr 9, 2022

bsunanda commented Apr 9, 2022

cmsbuild commented Apr 9, 2022

cmsbuild commented Apr 9, 2022

cmsbuild commented Apr 9, 2022

tvami commented Apr 9, 2022

cmsbuild commented Apr 9, 2022

qliphy commented Apr 10, 2022

		int k0 = (year == 17) ? 11 : 0;
		for (int k = k0; k < 22; ++k) {

Run3-alca222 Update some of the macros usedin calibrating HCAL with isotrack or muon #37504

Run3-alca222 Update some of the macros usedin calibrating HCAL with isotrack or muon #37504

Conversation

bsunanda commented Apr 8, 2022

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Apr 8, 2022

cmsbuild commented Apr 8, 2022

cmsbuild commented Apr 8, 2022

tvami Apr 8, 2022

Choose a reason for hiding this comment

tvami Apr 8, 2022

Choose a reason for hiding this comment

tvami commented Apr 8, 2022

cmsbuild commented Apr 9, 2022

bsunanda commented Apr 9, 2022

cmsbuild commented Apr 9, 2022

cmsbuild commented Apr 9, 2022

cmsbuild commented Apr 9, 2022

Comparison Summary

tvami commented Apr 9, 2022

cmsbuild commented Apr 9, 2022

qliphy commented Apr 10, 2022