Add typedefs for association quality and tag template argument types.

[osschar]

This PR adds two typedefs needed for creation of JIT-compiled lambdas for quality selection filters in FireworksWeb.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37515/29230

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @osschar (Matevž Tadel) for master.

It involves the following packages:

• DataFormats/Common (core)

@cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks.
@makortel, @wddgit, @rovere this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[makortel]

@cmsbuild, please test

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c7a84a/23800/summary.html
COMMIT: c19c23d
CMSSW: CMSSW_12_4_X_2022-04-09-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37515/23800/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

• 134.99602134.99602_RunZeroBias2015HLHS+RunZeroBias2015HLHS+HLTDR2_25ns+RECODR2_25nsreHLT_HIPM+HARVESTDR2/step2_RunZeroBias2015HLHS+RunZeroBias2015HLHS+HLTDR2_25ns+RECODR2_25nsreHLT_HIPM+HARVESTDR2.log
• 1365.01365.0_BuToJpsiK_13+BuToJpsiK_13INPUT+DIGIUP15+RECOUP15+HARVESTUP15/step2_BuToJpsiK_13+BuToJpsiK_13INPUT+DIGIUP15+RECOUP15+HARVESTUP15.log
• 1366.01366.0_BsToJpsiPhi_13+BsToJpsiPhi_13INPUT+DIGIUP15+RECOUP15+HARVESTUP15/step2_BsToJpsiPhi_13+BsToJpsiPhi_13INPUT+DIGIUP15+RECOUP15+HARVESTUP15.log

Expand to see more relval errors ...

• 1325.7
• 1329.1
• 1325.8
• 139901.0
• 13992501.0
• 139902.0
• 144.6
• 13992502.0
• 200.0
• 202.0
• 203.0
• 205.0
• 11024.2
• 25200.0
• 25202.0
• 25202.1
• 25202.2
• 25203.0
• 25204.0
• 25205.0
• 25206.0
• 25207.0
• 25208.0
• 25214.0
• 50200.0
• 50202.0
• 25209.0
• 50203.0
• 50204.0
• 50205.0
• 50206.0
• 50207.0
• 50208.0
• 1004.0
• 1000.0
• 1001.0
• 1020.0
• 1001.2
• 1010.0
• 1002.0
• 1354.0
• 1353.0
• 134.99601
• 1364.0
• 1355.0
• 1003.0
• 1352.0
• 134.0
• 1030.0
• 1325.6
• 1325.5161
• 1040.0
• 1325.516
• 1325.518
• 134.99901
• 1345.0
• 1344.0
• 1343.0
• 1350.0
• 1347.0
• 1351.0
• 1349.0
• 1040.1
• 1348.0
• 1102.0
• 1041.0
• 1042.0
• 4000.0
• 4001.0
• 134.99603
• 4002.0
• 4003.0
• 10001.0
• 10002.0
• 1325.61
• 10003.0
• 1325.81
• 10004.0
• 10005.0
• 10006.0
• 10007.0
• 10008.0
• 10009.0
• 10023.0
• 10024.0
• 10024.1
• 10024.2
• 10024.3
• 10024.4
• 10024.5
• 10025.0
• 10026.0
• 10042.0
• 10059.0
• 10071.0
• 10224.0
• 10225.0
• 1325.5
• 10424.0
• 10801.0
• 10802.0
• 10803.0
• 10804.0
• 10805.0
• 10806.0
• 10807.0
• 10808.0
• 10809.0
• 10823.0
• 10824.0
• 10824.1
• 10824.5
• 10824.501
• 10824.505
• 10824.511
• 10824.521
• 10824.6
• 10824.8
• 10825.0
• 10826.0
• 10842.0
• 10842.501
• 10842.505
• 10859.0
• 10871.0
• 11024.0
• 11024.6
• 11025.0
• 11224.0
• 11224.6
• 11601.0
• 11602.0
• 11603.0
• 11604.0
• 11605.0
• 11606.0
• 11607.0
• 11608.0
• 11609.0
• 11630.0
• 11634.0
• 11634.1
• 11634.24
• 11634.5
• 11634.501
• 11634.505
• 11634.511
• 11634.521
• 11634.7
• 11634.91
• 11640.0
• 11643.0
• 11646.0
• 11650.0
• 11650.501
• 11650.505
• 11723.17
• 11725.0
• 11834.0
• 11834.13
• 11834.21
• 11834.24
• 11834.99
• 11846.0
• 11925.0
• 12034.0
• 12434.0
• 12634.0
• 12634.99
• 12834.0
• 13034.0
• 13034.99
• 23234.0
• 23234.21
• 23434.21
• 23434.99
• 23434.9921
• 23434.999
• 34634.0
• 35034.0
• 39434.0
• 39434.103
• 39434.21
• 39434.5
• 39434.501
• 39434.502
• 39434.9
• 39496.0
• 39500.0
• 39634.21
• 39634.99
• 39634.9921
• 39634.999
• 250200.0
• 250200.17
• 250200.18
• 250202.0
• 250202.1
• 250202.17
• 250202.171
• 250202.172
• 250202.18
• 250202.181
• 250202.2
• 250202.3
• 250202.4
• 250202.5
• 250203.0
• 250203.17
• 250203.18
• 250204.0
• 250204.17
• 250204.18
• 250205.0
• 250205.17
• 250205.18
• 250206.0
• 250206.17
• 250206.18
• 250206.181
• 250207.0
• 250207.17
• 250207.18
• 250208.17
• 250208.18
• 500200.0
• 500202.0
• 500203.0
• 500204.0
• 500205.0
• 500206.0
• 500207.0

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3593039
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3593015
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 200 log files, 45 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[VinInn]

maybe it's time to enforce a transition to using for alias declarations.

[osschar]

agreed ... we just mimicked the existing style in affected files.

[makortel]

@cmsbuild, please test

Errors are clearly unrelated, but let's try again

[makortel]

maybe it's time to enforce a transition to using for alias declarations.

I see at least the HEAD of clang-tidy has modernize-use-using check to convert typedef into using. I wasn't able to quickly find though at which version this check has been introduced. Maybe the LLVM 14 update (cms-sw/cmsdist#7729) gives an opportunity to take a look of modernization checks that have been added since 12. @smuzaffar, what do you think?

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c7a84a/23810/summary.html
COMMIT: c19c23d
CMSSW: CMSSW_12_4_X_2022-04-10-0000/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37515/23810/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 10 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3593039
• DQMHistoTests: Total failures: 19
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3592997
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 47 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 200 log files, 45 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[makortel]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1