Phase2-gex127M Make some protection in accessing inpu collections for MTD so that some FasTsim tests can proceed

[bsunanda]

PR description:

Make some protection in accessing inpu collections for MTD so that some FasTsim tests can proceed

PR validation:

Use the runTheMatrix test workflows

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37517/29232

• This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37517/29232/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37517/29232/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37517/29233

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

• RecoLocalFastTime/FTLClusterizer (upgrade, reconstruction)
• RecoLocalFastTime/FTLRecProducers (upgrade, reconstruction)
• SimFastTiming/FastTimingCommon (upgrade, simulation)

@civanch, @clacaputo, @AdrianoDee, @srimanob, @mdhildreth, @slava77, @jpata can you please review it and eventually sign? Thanks.
@fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f14473/23807/summary.html
COMMIT: e970cab
CMSSW: CMSSW_12_4_X_2022-04-10-0000/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37517/23807/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3593039
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3593009
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 200 log files, 45 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[jpata]

Can you provide some details on the changes to the log verbosity in production? Or do I understand correctly that since it would have resulted in a crash, this code is not running in any default production?

[bsunanda]

For regular workflows in production or standard relval's, we do not come across these warnings. We get stuck when we try to develop FastSim workflows for Phase2 scenario. Once the workflows are fully developed, we would not get these mising collections.

[fabiocos]

To my knowledge there was never work on Fastsim on MTD side, the code was always supposed to work for Fullsim, as it does already. Anyway the additional protection is clearly welcome, although on regular Fastsim should not change anything.

[jpata]

+reconstruction

• prevents crash in Phase2 FastSim (not running by default anywhere)
• no changes to reco

[srimanob]

+Upgrade

This is a technical PR to add the protection of missing collections. The aim is for Phase-2 FastSim dev. There is no change expected for existing FullSim workflow.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1